Commit 3cea33b6 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown

ASoC: max98390: Fix error codes in max98390_dsm_init()

These error paths return success but they should return -EINVAL.

Fixes: 97ed3e50 ("ASoC: max98390: Fix potential crash during param fw loading")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X9B0uz4svyNTqeMb@mwandaSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1bea2256
...@@ -784,6 +784,7 @@ static int max98390_dsm_init(struct snd_soc_component *component) ...@@ -784,6 +784,7 @@ static int max98390_dsm_init(struct snd_soc_component *component)
if (fw->size < MAX98390_DSM_PARAM_MIN_SIZE) { if (fw->size < MAX98390_DSM_PARAM_MIN_SIZE) {
dev_err(component->dev, dev_err(component->dev,
"param fw is invalid.\n"); "param fw is invalid.\n");
ret = -EINVAL;
goto err_alloc; goto err_alloc;
} }
dsm_param = (char *)fw->data; dsm_param = (char *)fw->data;
...@@ -794,6 +795,7 @@ static int max98390_dsm_init(struct snd_soc_component *component) ...@@ -794,6 +795,7 @@ static int max98390_dsm_init(struct snd_soc_component *component)
fw->size < param_size + MAX98390_DSM_PAYLOAD_OFFSET) { fw->size < param_size + MAX98390_DSM_PAYLOAD_OFFSET) {
dev_err(component->dev, dev_err(component->dev,
"param fw is invalid.\n"); "param fw is invalid.\n");
ret = -EINVAL;
goto err_alloc; goto err_alloc;
} }
regmap_write(max98390->regmap, MAX98390_R203A_AMP_EN, 0x80); regmap_write(max98390->regmap, MAX98390_R203A_AMP_EN, 0x80);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment