Commit 3d9939c9 authored by Wei Yongjun's avatar Wei Yongjun Committed by Jason Cooper

pci: mvebu: fix return value check in mvebu_pcie_probe()

In case of error, function of_clk_get_by_name() returns
ERR_PTR() never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: default avatarJason Cooper <jason@lakedaemon.net>
parent bda7aabd
...@@ -828,7 +828,7 @@ static int __init mvebu_pcie_probe(struct platform_device *pdev) ...@@ -828,7 +828,7 @@ static int __init mvebu_pcie_probe(struct platform_device *pdev)
} }
port->clk = of_clk_get_by_name(child, NULL); port->clk = of_clk_get_by_name(child, NULL);
if (!port->clk) { if (IS_ERR(port->clk)) {
dev_err(&pdev->dev, "PCIe%d.%d: cannot get clock\n", dev_err(&pdev->dev, "PCIe%d.%d: cannot get clock\n",
port->port, port->lane); port->port, port->lane);
iounmap(port->base); iounmap(port->base);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment