Commit 3e0c1abe authored by Iwo Mergler's avatar Iwo Mergler Committed by John W. Linville

rt2x00: Large vendor requests for rt73usb firmware upload and beacons

Switches rt73usb to use large vendor requests for firmware
and beacons. This also fixes the garbled beacon bug.
Signed-off-by: default avatarIwo Mergler <Iwo@call-direct.com.au>
Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent ed0dbeeb
...@@ -71,7 +71,6 @@ ...@@ -71,7 +71,6 @@
* Cache size * Cache size
*/ */
#define CSR_CACHE_SIZE 64 #define CSR_CACHE_SIZE 64
#define CSR_CACHE_SIZE_FIRMWARE 64
/* /*
* USB request types. * USB request types.
......
...@@ -890,9 +890,6 @@ static int rt73usb_load_firmware(struct rt2x00_dev *rt2x00dev, const void *data, ...@@ -890,9 +890,6 @@ static int rt73usb_load_firmware(struct rt2x00_dev *rt2x00dev, const void *data,
unsigned int i; unsigned int i;
int status; int status;
u32 reg; u32 reg;
const char *ptr = data;
char *cache;
int buflen;
/* /*
* Wait for stable hardware. * Wait for stable hardware.
...@@ -911,31 +908,12 @@ static int rt73usb_load_firmware(struct rt2x00_dev *rt2x00dev, const void *data, ...@@ -911,31 +908,12 @@ static int rt73usb_load_firmware(struct rt2x00_dev *rt2x00dev, const void *data,
/* /*
* Write firmware to device. * Write firmware to device.
* We setup a seperate cache for this action,
* since we are going to write larger chunks of data
* then normally used cache size.
*/ */
cache = kmalloc(CSR_CACHE_SIZE_FIRMWARE, GFP_KERNEL); rt2x00usb_vendor_request_large_buff(rt2x00dev, USB_MULTI_WRITE,
if (!cache) { USB_VENDOR_REQUEST_OUT,
ERROR(rt2x00dev, "Failed to allocate firmware cache.\n"); FIRMWARE_IMAGE_BASE,
return -ENOMEM; data, len,
} REGISTER_TIMEOUT32(len));
for (i = 0; i < len; i += CSR_CACHE_SIZE_FIRMWARE) {
buflen = min_t(int, len - i, CSR_CACHE_SIZE_FIRMWARE);
memcpy(cache, ptr, buflen);
rt2x00usb_vendor_request(rt2x00dev, USB_MULTI_WRITE,
USB_VENDOR_REQUEST_OUT,
FIRMWARE_IMAGE_BASE + i, 0,
cache, buflen,
REGISTER_TIMEOUT32(buflen));
ptr += buflen;
}
kfree(cache);
/* /*
* Send firmware request to device to load firmware, * Send firmware request to device to load firmware,
...@@ -1374,10 +1352,10 @@ static void rt73usb_write_beacon(struct queue_entry *entry) ...@@ -1374,10 +1352,10 @@ static void rt73usb_write_beacon(struct queue_entry *entry)
* Write entire beacon with descriptor to register. * Write entire beacon with descriptor to register.
*/ */
beacon_base = HW_BEACON_OFFSET(entry->entry_idx); beacon_base = HW_BEACON_OFFSET(entry->entry_idx);
rt2x00usb_vendor_request(rt2x00dev, USB_MULTI_WRITE, rt2x00usb_vendor_request_large_buff(rt2x00dev, USB_MULTI_WRITE,
USB_VENDOR_REQUEST_OUT, beacon_base, 0, USB_VENDOR_REQUEST_OUT, beacon_base,
entry->skb->data, entry->skb->len, entry->skb->data, entry->skb->len,
REGISTER_TIMEOUT32(entry->skb->len)); REGISTER_TIMEOUT32(entry->skb->len));
/* /*
* Clean up the beacon skb. * Clean up the beacon skb.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment