Commit 3e94fb8f authored by Roland Dreier's avatar Roland Dreier Committed by Andi Kleen

[PATCH] x86-64: avoid warning message livelock

I've seen my box paralyzed by an endless spew of

    rtc: lost some interrupts at 1024Hz.

messages on the serial console.  What seems to be happening is that
something real causes an interrupt to be lost and triggers the
message.  But then printing the message to the serial console (from
the hpet interrupt handler) takes more than 1/1024th of a second, and
then some more interrupts are lost, so the message triggers again....

Fix this by adding a printk_ratelimit() before printing the warning.
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAndi Kleen <ak@suse.de>
parent ee4eff6f
...@@ -1226,8 +1226,9 @@ static void hpet_rtc_timer_reinit(void) ...@@ -1226,8 +1226,9 @@ static void hpet_rtc_timer_reinit(void)
if (PIE_on) if (PIE_on)
PIE_count += lost_ints; PIE_count += lost_ints;
printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", if (printk_ratelimit())
hpet_rtc_int_freq); printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n",
hpet_rtc_int_freq);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment