Commit 3ecfc913 authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul

dmaengine: idxd: add driver register helper

Add helper functions for dsa-driver registration similar to other
bus-types. In particular, do not require dsa-drivers to open-code the
bus, owner, and mod_name fields. Let registration and unregistration
operate on the 'struct idxd_device_driver' instead of the raw /
embedded 'struct device_driver'.
Reviewed-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/162637458949.744545.14996726325385482050.stgit@djiang5-desk3.ch.intel.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 88c5d0a2
...@@ -402,6 +402,13 @@ static inline int idxd_wq_refcount(struct idxd_wq *wq) ...@@ -402,6 +402,13 @@ static inline int idxd_wq_refcount(struct idxd_wq *wq)
return wq->client_count; return wq->client_count;
}; };
int __must_check __idxd_driver_register(struct idxd_device_driver *idxd_drv,
struct module *module, const char *mod_name);
#define idxd_driver_register(driver) \
__idxd_driver_register(driver, THIS_MODULE, KBUILD_MODNAME)
void idxd_driver_unregister(struct idxd_device_driver *idxd_drv);
int idxd_register_bus_type(void); int idxd_register_bus_type(void);
void idxd_unregister_bus_type(void); void idxd_unregister_bus_type(void);
int idxd_register_devices(struct idxd_device *idxd); int idxd_register_devices(struct idxd_device *idxd);
......
...@@ -855,3 +855,20 @@ static void __exit idxd_exit_module(void) ...@@ -855,3 +855,20 @@ static void __exit idxd_exit_module(void)
perfmon_exit(); perfmon_exit();
} }
module_exit(idxd_exit_module); module_exit(idxd_exit_module);
int __idxd_driver_register(struct idxd_device_driver *idxd_drv, struct module *owner,
const char *mod_name)
{
struct device_driver *drv = &idxd_drv->drv;
drv->bus = &dsa_bus_type;
drv->owner = owner;
drv->mod_name = mod_name;
return driver_register(drv);
}
void idxd_driver_unregister(struct idxd_device_driver *idxd_drv)
{
driver_unregister(&idxd_drv->drv);
}
...@@ -313,21 +313,18 @@ struct bus_type dsa_bus_type = { ...@@ -313,21 +313,18 @@ struct bus_type dsa_bus_type = {
static struct idxd_device_driver dsa_drv = { static struct idxd_device_driver dsa_drv = {
.drv = { .drv = {
.name = "dsa", .name = "dsa",
.bus = &dsa_bus_type,
.owner = THIS_MODULE,
.mod_name = KBUILD_MODNAME,
}, },
}; };
/* IDXD generic driver setup */ /* IDXD generic driver setup */
int idxd_register_driver(void) int idxd_register_driver(void)
{ {
return driver_register(&dsa_drv.drv); return idxd_driver_register(&dsa_drv);
} }
void idxd_unregister_driver(void) void idxd_unregister_driver(void)
{ {
driver_unregister(&dsa_drv.drv); idxd_driver_unregister(&dsa_drv);
} }
/* IDXD engine attributes */ /* IDXD engine attributes */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment