Commit 3f0bdb2e authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher

fm10k: allow creation of VLAN interfaces even while down

We re-sync upon going up, so there is little reason to worry about not
syncing immediately with switch. This prevents an error that occurs if
you add a VLAN interface while down.
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarKrishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 0ff36676
...@@ -779,6 +779,12 @@ static int fm10k_update_vid(struct net_device *netdev, u16 vid, bool set) ...@@ -779,6 +779,12 @@ static int fm10k_update_vid(struct net_device *netdev, u16 vid, bool set)
if (!set && vid == hw->mac.default_vid) if (!set && vid == hw->mac.default_vid)
return 0; return 0;
/* Do not throw an error if the interface is down. We will sync once
* we come up
*/
if (test_bit(__FM10K_DOWN, &interface->state))
return 0;
fm10k_mbx_lock(interface); fm10k_mbx_lock(interface);
/* only need to update the VLAN if not in promiscuous mode */ /* only need to update the VLAN if not in promiscuous mode */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment