Commit 3f706088 authored by Davidlohr Bueso's avatar Davidlohr Bueso Committed by Mauro Carvalho Chehab

[media] media/usbvision: remove ctrl_urb_wq

While the wakeup path seems to be set up, this waitqueue is actually
never used as no-one enqueues themselves on the list. As such, wakeups
are meaningless without waiters, so lets just get rid of the whole
thing.
Signed-off-by: default avatarDavidlohr Bueso <dbueso@suse.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 1059b687
...@@ -1413,8 +1413,6 @@ static void usbvision_ctrl_urb_complete(struct urb *urb) ...@@ -1413,8 +1413,6 @@ static void usbvision_ctrl_urb_complete(struct urb *urb)
PDEBUG(DBG_IRQ, ""); PDEBUG(DBG_IRQ, "");
usbvision->ctrl_urb_busy = 0; usbvision->ctrl_urb_busy = 0;
if (waitqueue_active(&usbvision->ctrl_urb_wq))
wake_up_interruptible(&usbvision->ctrl_urb_wq);
} }
......
...@@ -1336,7 +1336,6 @@ static struct usb_usbvision *usbvision_alloc(struct usb_device *dev, ...@@ -1336,7 +1336,6 @@ static struct usb_usbvision *usbvision_alloc(struct usb_device *dev,
usbvision->ctrl_urb = usb_alloc_urb(USBVISION_URB_FRAMES, GFP_KERNEL); usbvision->ctrl_urb = usb_alloc_urb(USBVISION_URB_FRAMES, GFP_KERNEL);
if (usbvision->ctrl_urb == NULL) if (usbvision->ctrl_urb == NULL)
goto err_unreg; goto err_unreg;
init_waitqueue_head(&usbvision->ctrl_urb_wq);
return usbvision; return usbvision;
......
...@@ -366,7 +366,6 @@ struct usb_usbvision { ...@@ -366,7 +366,6 @@ struct usb_usbvision {
unsigned char ctrl_urb_buffer[8]; unsigned char ctrl_urb_buffer[8];
int ctrl_urb_busy; int ctrl_urb_busy;
struct usb_ctrlrequest ctrl_urb_setup; struct usb_ctrlrequest ctrl_urb_setup;
wait_queue_head_t ctrl_urb_wq; /* Processes waiting */
/* configuration part */ /* configuration part */
int have_tuner; int have_tuner;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment