Commit 3f8958cf authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Mark Brown

spi: atmel: Remove needless bits_per_word and speed_hz tests

SPI core validates both bits_per_word and speed_hz transfer parameters and
defaults to spi->bits_per_word and spi->max_speed_hz in case these per
transfer parameters are not set. This makes possible to remove two if
statements and remove one code block that is never executed.
Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent aab7826f
...@@ -871,14 +871,7 @@ static int atmel_spi_set_xfer_speed(struct atmel_spi *as, ...@@ -871,14 +871,7 @@ static int atmel_spi_set_xfer_speed(struct atmel_spi *as,
* Calculate the lowest divider that satisfies the * Calculate the lowest divider that satisfies the
* constraint, assuming div32/fdiv/mbz == 0. * constraint, assuming div32/fdiv/mbz == 0.
*/ */
if (xfer->speed_hz) scbr = DIV_ROUND_UP(bus_hz, xfer->speed_hz);
scbr = DIV_ROUND_UP(bus_hz, xfer->speed_hz);
else
/*
* This can happend if max_speed is null.
* In this case, we set the lowest possible speed
*/
scbr = 0xff;
/* /*
* If the resulting divider doesn't fit into the * If the resulting divider doesn't fit into the
...@@ -1300,14 +1293,12 @@ static int atmel_spi_one_transfer(struct spi_master *master, ...@@ -1300,14 +1293,12 @@ static int atmel_spi_one_transfer(struct spi_master *master,
return -EINVAL; return -EINVAL;
} }
if (xfer->bits_per_word) { asd = spi->controller_state;
asd = spi->controller_state; bits = (asd->csr >> 4) & 0xf;
bits = (asd->csr >> 4) & 0xf; if (bits != xfer->bits_per_word - 8) {
if (bits != xfer->bits_per_word - 8) { dev_dbg(&spi->dev,
dev_dbg(&spi->dev,
"you can't yet change bits_per_word in transfers\n"); "you can't yet change bits_per_word in transfers\n");
return -ENOPROTOOPT; return -ENOPROTOOPT;
}
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment