Commit 3f8b9bbc authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans Verkuil

media: s5p_cec: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 9cc5b012
...@@ -249,14 +249,13 @@ static int s5p_cec_probe(struct platform_device *pdev) ...@@ -249,14 +249,13 @@ static int s5p_cec_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int s5p_cec_remove(struct platform_device *pdev) static void s5p_cec_remove(struct platform_device *pdev)
{ {
struct s5p_cec_dev *cec = platform_get_drvdata(pdev); struct s5p_cec_dev *cec = platform_get_drvdata(pdev);
cec_notifier_cec_adap_unregister(cec->notifier, cec->adap); cec_notifier_cec_adap_unregister(cec->notifier, cec->adap);
cec_unregister_adapter(cec->adap); cec_unregister_adapter(cec->adap);
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
return 0;
} }
static int __maybe_unused s5p_cec_runtime_suspend(struct device *dev) static int __maybe_unused s5p_cec_runtime_suspend(struct device *dev)
...@@ -295,7 +294,7 @@ MODULE_DEVICE_TABLE(of, s5p_cec_match); ...@@ -295,7 +294,7 @@ MODULE_DEVICE_TABLE(of, s5p_cec_match);
static struct platform_driver s5p_cec_pdrv = { static struct platform_driver s5p_cec_pdrv = {
.probe = s5p_cec_probe, .probe = s5p_cec_probe,
.remove = s5p_cec_remove, .remove_new = s5p_cec_remove,
.driver = { .driver = {
.name = CEC_NAME, .name = CEC_NAME,
.of_match_table = s5p_cec_match, .of_match_table = s5p_cec_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment