Commit 3f9a1b35 authored by Stephane Eranian's avatar Stephane Eranian Committed by Peter Zijlstra

perf/x86/amd/lbr: Adjust LBR regardless of filtering

In case of fused compare and taken branch instructions, the AMD LBR points to
the compare instruction instead of the branch. Users of LBR usually expects
the from address to point to a branch instruction. The kernel has code to
adjust the from address via get_branch_type_fused(). However this correction
is only applied when a branch filter is applied. That means that if no
filter is present, the quality of the data is lower.

Fix the problem by applying the adjustment regardless of the filter setting,
bringing the AMD LBR to the same level as other LBR implementations.

Fixes: 245268c1 ("perf/x86/amd/lbr: Use fusion-aware branch classifier")
Signed-off-by: default avatarStephane Eranian <eranian@google.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarSandipan Das <sandipan.das@amd.com>
Link: https://lore.kernel.org/r/20220928184043.408364-3-eranian@google.com
parent 117ceeb1
...@@ -99,12 +99,13 @@ static void amd_pmu_lbr_filter(void) ...@@ -99,12 +99,13 @@ static void amd_pmu_lbr_filter(void)
struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events); struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
int br_sel = cpuc->br_sel, offset, type, i, j; int br_sel = cpuc->br_sel, offset, type, i, j;
bool compress = false; bool compress = false;
bool fused_only = false;
u64 from, to; u64 from, to;
/* If sampling all branches, there is nothing to filter */ /* If sampling all branches, there is nothing to filter */
if (((br_sel & X86_BR_ALL) == X86_BR_ALL) && if (((br_sel & X86_BR_ALL) == X86_BR_ALL) &&
((br_sel & X86_BR_TYPE_SAVE) != X86_BR_TYPE_SAVE)) ((br_sel & X86_BR_TYPE_SAVE) != X86_BR_TYPE_SAVE))
return; fused_only = true;
for (i = 0; i < cpuc->lbr_stack.nr; i++) { for (i = 0; i < cpuc->lbr_stack.nr; i++) {
from = cpuc->lbr_entries[i].from; from = cpuc->lbr_entries[i].from;
...@@ -116,8 +117,11 @@ static void amd_pmu_lbr_filter(void) ...@@ -116,8 +117,11 @@ static void amd_pmu_lbr_filter(void)
* fusion where it points to an instruction preceding the * fusion where it points to an instruction preceding the
* actual branch * actual branch
*/ */
if (offset) if (offset) {
cpuc->lbr_entries[i].from += offset; cpuc->lbr_entries[i].from += offset;
if (fused_only)
continue;
}
/* If type does not correspond, then discard */ /* If type does not correspond, then discard */
if (type == X86_BR_NONE || (br_sel & type) != type) { if (type == X86_BR_NONE || (br_sel & type) != type) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment