Commit 3fc7b4b2 authored by Roland Dreier's avatar Roland Dreier Committed by Linus Torvalds

lib: export generic atomic64_t functions

The generic atomic64_t implementation in lib/ did not export the functions
it defined, which means that modules that use atomic64_t would not link on
platforms (such as 32-bit powerpc).  For example, trying to build a kernel
with CONFIG_NET_RDS on such a platform would fail with:

    ERROR: "atomic64_read" [net/rds/rds.ko] undefined!
    ERROR: "atomic64_set" [net/rds/rds.ko] undefined!

Fix this by exporting the atomic64_t functions to modules.  (I export the
entire API even if it's not all currently used by in-tree modules to avoid
having to continue fixing this in dribs and drabs)
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
Acked-by: default avatarPaul Mackerras <paulus@samba.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e4c6f8be
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include <linux/cache.h> #include <linux/cache.h>
#include <linux/spinlock.h> #include <linux/spinlock.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/module.h>
#include <asm/atomic.h> #include <asm/atomic.h>
/* /*
...@@ -52,6 +53,7 @@ long long atomic64_read(const atomic64_t *v) ...@@ -52,6 +53,7 @@ long long atomic64_read(const atomic64_t *v)
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
return val; return val;
} }
EXPORT_SYMBOL(atomic64_read);
void atomic64_set(atomic64_t *v, long long i) void atomic64_set(atomic64_t *v, long long i)
{ {
...@@ -62,6 +64,7 @@ void atomic64_set(atomic64_t *v, long long i) ...@@ -62,6 +64,7 @@ void atomic64_set(atomic64_t *v, long long i)
v->counter = i; v->counter = i;
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
} }
EXPORT_SYMBOL(atomic64_set);
void atomic64_add(long long a, atomic64_t *v) void atomic64_add(long long a, atomic64_t *v)
{ {
...@@ -72,6 +75,7 @@ void atomic64_add(long long a, atomic64_t *v) ...@@ -72,6 +75,7 @@ void atomic64_add(long long a, atomic64_t *v)
v->counter += a; v->counter += a;
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
} }
EXPORT_SYMBOL(atomic64_add);
long long atomic64_add_return(long long a, atomic64_t *v) long long atomic64_add_return(long long a, atomic64_t *v)
{ {
...@@ -84,6 +88,7 @@ long long atomic64_add_return(long long a, atomic64_t *v) ...@@ -84,6 +88,7 @@ long long atomic64_add_return(long long a, atomic64_t *v)
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
return val; return val;
} }
EXPORT_SYMBOL(atomic64_add_return);
void atomic64_sub(long long a, atomic64_t *v) void atomic64_sub(long long a, atomic64_t *v)
{ {
...@@ -94,6 +99,7 @@ void atomic64_sub(long long a, atomic64_t *v) ...@@ -94,6 +99,7 @@ void atomic64_sub(long long a, atomic64_t *v)
v->counter -= a; v->counter -= a;
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
} }
EXPORT_SYMBOL(atomic64_sub);
long long atomic64_sub_return(long long a, atomic64_t *v) long long atomic64_sub_return(long long a, atomic64_t *v)
{ {
...@@ -106,6 +112,7 @@ long long atomic64_sub_return(long long a, atomic64_t *v) ...@@ -106,6 +112,7 @@ long long atomic64_sub_return(long long a, atomic64_t *v)
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
return val; return val;
} }
EXPORT_SYMBOL(atomic64_sub_return);
long long atomic64_dec_if_positive(atomic64_t *v) long long atomic64_dec_if_positive(atomic64_t *v)
{ {
...@@ -120,6 +127,7 @@ long long atomic64_dec_if_positive(atomic64_t *v) ...@@ -120,6 +127,7 @@ long long atomic64_dec_if_positive(atomic64_t *v)
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
return val; return val;
} }
EXPORT_SYMBOL(atomic64_dec_if_positive);
long long atomic64_cmpxchg(atomic64_t *v, long long o, long long n) long long atomic64_cmpxchg(atomic64_t *v, long long o, long long n)
{ {
...@@ -134,6 +142,7 @@ long long atomic64_cmpxchg(atomic64_t *v, long long o, long long n) ...@@ -134,6 +142,7 @@ long long atomic64_cmpxchg(atomic64_t *v, long long o, long long n)
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
return val; return val;
} }
EXPORT_SYMBOL(atomic64_cmpxchg);
long long atomic64_xchg(atomic64_t *v, long long new) long long atomic64_xchg(atomic64_t *v, long long new)
{ {
...@@ -147,6 +156,7 @@ long long atomic64_xchg(atomic64_t *v, long long new) ...@@ -147,6 +156,7 @@ long long atomic64_xchg(atomic64_t *v, long long new)
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
return val; return val;
} }
EXPORT_SYMBOL(atomic64_xchg);
int atomic64_add_unless(atomic64_t *v, long long a, long long u) int atomic64_add_unless(atomic64_t *v, long long a, long long u)
{ {
...@@ -162,6 +172,7 @@ int atomic64_add_unless(atomic64_t *v, long long a, long long u) ...@@ -162,6 +172,7 @@ int atomic64_add_unless(atomic64_t *v, long long a, long long u)
spin_unlock_irqrestore(lock, flags); spin_unlock_irqrestore(lock, flags);
return ret; return ret;
} }
EXPORT_SYMBOL(atomic64_add_unless);
static int init_atomic64_lock(void) static int init_atomic64_lock(void)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment