Commit 3fde85df authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

vt_ioctl: return -EFAULT on copy_from_user errors

copy_from_user() returns the number of bytes remaining but we want to
return a negative error code here.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent c1bfffa9
...@@ -1303,7 +1303,9 @@ int vt_ioctl(struct tty_struct *tty, struct file * file, ...@@ -1303,7 +1303,9 @@ int vt_ioctl(struct tty_struct *tty, struct file * file,
if (!perm) if (!perm)
goto eperm; goto eperm;
ret = copy_from_user(&ui, up, sizeof(struct unimapinit)); ret = copy_from_user(&ui, up, sizeof(struct unimapinit));
if (!ret) if (ret)
ret = -EFAULT;
else
con_clear_unimap(vc, &ui); con_clear_unimap(vc, &ui);
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment