Commit 40619f7d authored by Aditya Pakki's avatar Aditya Pakki Committed by Rafael J. Wysocki

PM: clock_ops: fix missing clk_prepare() return value check

clk_prepare() can fail, so check its status and if it fails,
issue an error message and change the clock_entry_status to
PCE_STATUS_ERROR.
Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
[ rjw: Subject ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 3b4ed2e2
...@@ -65,10 +65,15 @@ static void pm_clk_acquire(struct device *dev, struct pm_clock_entry *ce) ...@@ -65,10 +65,15 @@ static void pm_clk_acquire(struct device *dev, struct pm_clock_entry *ce)
if (IS_ERR(ce->clk)) { if (IS_ERR(ce->clk)) {
ce->status = PCE_STATUS_ERROR; ce->status = PCE_STATUS_ERROR;
} else { } else {
clk_prepare(ce->clk); if (clk_prepare(ce->clk)) {
ce->status = PCE_STATUS_ACQUIRED; ce->status = PCE_STATUS_ERROR;
dev_dbg(dev, "Clock %pC con_id %s managed by runtime PM.\n", dev_err(dev, "clk_prepare() failed\n");
ce->clk, ce->con_id); } else {
ce->status = PCE_STATUS_ACQUIRED;
dev_dbg(dev,
"Clock %pC con_id %s managed by runtime PM.\n",
ce->clk, ce->con_id);
}
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment