Commit 40662333 authored by Nathan Huckleberry's avatar Nathan Huckleberry Committed by Jakub Kicinski

net: ethernet: litex: Fix return type of liteeth_start_xmit

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of liteeth_start_xmit should be changed from int to
netdev_tx_t.
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: default avatarNathan Huckleberry <nhuck@google.com>
Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Acked-by: default avatarGabriel Somlo <gsomlo@gmail.com>
Link: https://lore.kernel.org/r/20220912195307.812229-1-nhuck@google.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5972ca94
......@@ -152,7 +152,8 @@ static int liteeth_stop(struct net_device *netdev)
return 0;
}
static int liteeth_start_xmit(struct sk_buff *skb, struct net_device *netdev)
static netdev_tx_t liteeth_start_xmit(struct sk_buff *skb,
struct net_device *netdev)
{
struct liteeth *priv = netdev_priv(netdev);
void __iomem *txbuffer;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment