Commit 40d344ec authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Ben Myers

xfs: mark the xfssyncd workqueue as non-reentrant

On a system with lots of memory pressure that is stuck on synchronous inode
reclaim the workqueue code will run one instance of the inode reclaim work
item on every CPU. which is not what we want.  Make sure to mark the
xfssyncd workqueue as non-reentrant to make sure there only is one instace
of each running globally.  Also stop using special paramater for the
workqueue; now that we guarantee each fs has only running one of each works
at a time there is no need to artificially lower max_active and compensate
for that by setting the WQ_CPU_INTENSIVE flag.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent 28fb588c
...@@ -1625,12 +1625,12 @@ STATIC int __init ...@@ -1625,12 +1625,12 @@ STATIC int __init
xfs_init_workqueues(void) xfs_init_workqueues(void)
{ {
/* /*
* max_active is set to 8 to give enough concurency to allow * We never want to the same work item to run twice, reclaiming inodes
* multiple work operations on each CPU to run. This allows multiple * or idling the log is not going to get any faster by multiple CPUs
* filesystems to be running sync work concurrently, and scales with * competing for ressources. Use the default large max_active value
* the number of CPUs in the system. * so that even lots of filesystems can perform these task in parallel.
*/ */
xfs_syncd_wq = alloc_workqueue("xfssyncd", WQ_CPU_INTENSIVE, 8); xfs_syncd_wq = alloc_workqueue("xfssyncd", WQ_NON_REENTRANT, 0);
if (!xfs_syncd_wq) if (!xfs_syncd_wq)
return -ENOMEM; return -ENOMEM;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment