Commit 41543c7c authored by Hans de Goede's avatar Hans de Goede Committed by Hans Verkuil

media: ov2740: Improve ov2740_check_hwcfg() error reporting

Make ov2740_check_hwcfg() report an error on failure in all error paths,
so that it is always clear why the probe() failed.
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 47913c1f
...@@ -940,7 +940,8 @@ static int ov2740_check_hwcfg(struct device *dev) ...@@ -940,7 +940,8 @@ static int ov2740_check_hwcfg(struct device *dev)
ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk); ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
if (ret) { if (ret) {
fwnode_handle_put(ep); fwnode_handle_put(ep);
return ret; return dev_err_probe(dev, ret,
"reading clock-frequency property\n");
} }
if (mclk != OV2740_MCLK) { if (mclk != OV2740_MCLK) {
...@@ -953,7 +954,7 @@ static int ov2740_check_hwcfg(struct device *dev) ...@@ -953,7 +954,7 @@ static int ov2740_check_hwcfg(struct device *dev)
ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg); ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
fwnode_handle_put(ep); fwnode_handle_put(ep);
if (ret) if (ret)
return ret; return dev_err_probe(dev, ret, "parsing endpoint failed\n");
if (bus_cfg.bus.mipi_csi2.num_data_lanes != OV2740_DATA_LANES) { if (bus_cfg.bus.mipi_csi2.num_data_lanes != OV2740_DATA_LANES) {
ret = dev_err_probe(dev, -EINVAL, ret = dev_err_probe(dev, -EINVAL,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment