Commit 415cd2a6 authored by Alexander Duyck's avatar Alexander Duyck Committed by Jeff Kirsher

igb: Fix sparse warning about passing __beXX into leXX_to_cpup

We were casting the addr as __beXX and then passing it into le32_to_cpu
because the device expects the MAC address to be in network order even
though the register set is little endian.  Instead of casting it as __beXX
we can just cast it as __leXX in order to maintain consistency since the
region of memory is already in little endian order as far as we are
concerned.
Signed-off-by: default avatarAlexander Duyck <aduyck@mirantis.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 4da46ceb
...@@ -7845,11 +7845,13 @@ static void igb_rar_set_qsel(struct igb_adapter *adapter, u8 *addr, u32 index, ...@@ -7845,11 +7845,13 @@ static void igb_rar_set_qsel(struct igb_adapter *adapter, u8 *addr, u32 index,
struct e1000_hw *hw = &adapter->hw; struct e1000_hw *hw = &adapter->hw;
u32 rar_low, rar_high; u32 rar_low, rar_high;
/* HW expects these in little endian so we reverse the byte order /* HW expects these to be in network order when they are plugged
* from network order (big endian) to CPU endian * into the registers which are little endian. In order to guarantee
* that ordering we need to do an leXX_to_cpup here in order to be
* ready for the byteswap that occurs with writel
*/ */
rar_low = le32_to_cpup((__be32 *)(addr)); rar_low = le32_to_cpup((__le32 *)(addr));
rar_high = le16_to_cpup((__be16 *)(addr + 4)); rar_high = le16_to_cpup((__le16 *)(addr + 4));
/* Indicate to hardware the Address is Valid. */ /* Indicate to hardware the Address is Valid. */
rar_high |= E1000_RAH_AV; rar_high |= E1000_RAH_AV;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment