Commit 41b21aeb authored by Niels de Vos's avatar Niels de Vos Committed by Tomi Valkeinen

OMAP: DSS2: OMAPFB: make DBG() more resistant in if-else constructions

When DBG() is used in a simple if-else, the resulting code path
currently depends on the definition of DBG(). Inserting the statement in
a "do { ... } while (0)" prevents this possible misuse.
Signed-off-by: default avatarNiels de Vos <ndevos@redhat.com>
[tomi.valkeinen@ti.com: changed the title of the commit msg]
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 0d548a27
...@@ -34,8 +34,10 @@ ...@@ -34,8 +34,10 @@
#ifdef DEBUG #ifdef DEBUG
extern unsigned int omapfb_debug; extern unsigned int omapfb_debug;
#define DBG(format, ...) \ #define DBG(format, ...) \
if (omapfb_debug) \ do { \
printk(KERN_DEBUG "OMAPFB: " format, ## __VA_ARGS__) if (omapfb_debug) \
printk(KERN_DEBUG "OMAPFB: " format, ## __VA_ARGS__); \
} while (0)
#else #else
#define DBG(format, ...) #define DBG(format, ...)
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment