Commit 428bbf4b authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans Verkuil

media: camss: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 8a7033f8
...@@ -1725,7 +1725,7 @@ void camss_delete(struct camss *camss) ...@@ -1725,7 +1725,7 @@ void camss_delete(struct camss *camss)
* *
* Always returns 0. * Always returns 0.
*/ */
static int camss_remove(struct platform_device *pdev) static void camss_remove(struct platform_device *pdev)
{ {
struct camss *camss = platform_get_drvdata(pdev); struct camss *camss = platform_get_drvdata(pdev);
...@@ -1735,8 +1735,6 @@ static int camss_remove(struct platform_device *pdev) ...@@ -1735,8 +1735,6 @@ static int camss_remove(struct platform_device *pdev)
if (atomic_read(&camss->ref_count) == 0) if (atomic_read(&camss->ref_count) == 0)
camss_delete(camss); camss_delete(camss);
return 0;
} }
static const struct of_device_id camss_dt_match[] = { static const struct of_device_id camss_dt_match[] = {
...@@ -1798,7 +1796,7 @@ static const struct dev_pm_ops camss_pm_ops = { ...@@ -1798,7 +1796,7 @@ static const struct dev_pm_ops camss_pm_ops = {
static struct platform_driver qcom_camss_driver = { static struct platform_driver qcom_camss_driver = {
.probe = camss_probe, .probe = camss_probe,
.remove = camss_remove, .remove_new = camss_remove,
.driver = { .driver = {
.name = "qcom-camss", .name = "qcom-camss",
.of_match_table = camss_dt_match, .of_match_table = camss_dt_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment