Commit 42f57874 authored by Heiko Stübner's avatar Heiko Stübner Committed by Dmitry Torokhov

Input: evdev - fix variable initialisation

Commit 509f87c5 (evdev - do not block waiting for an event if fd
is nonblock) created a code path were it was possible to use retval
uninitialized.

This could lead to the xorg evdev input driver getting corrupt data
and refusing to work with log messages like
	AUO-Pixcir touchscreen: Read error: Success
	sg060_keys: Read error: Success
	AUO-Pixcir touchscreen: Read error: Success
	sg060_keys: Read error: Success
(for drivers auo-pixcir-ts and gpio-keys).
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Acked-by: default avatarDima Zavin <dima@android.com>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent 52965cc0
...@@ -386,7 +386,7 @@ static ssize_t evdev_read(struct file *file, char __user *buffer, ...@@ -386,7 +386,7 @@ static ssize_t evdev_read(struct file *file, char __user *buffer,
struct evdev_client *client = file->private_data; struct evdev_client *client = file->private_data;
struct evdev *evdev = client->evdev; struct evdev *evdev = client->evdev;
struct input_event event; struct input_event event;
int retval; int retval = 0;
if (count < input_event_size()) if (count < input_event_size())
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment