Commit 4327ba52 authored by Daeho Jeong's avatar Daeho Jeong Committed by Theodore Ts'o

ext4, jbd2: ensure entering into panic after recording an error in superblock

If a EXT4 filesystem utilizes JBD2 journaling and an error occurs, the
journaling will be aborted first and the error number will be recorded
into JBD2 superblock and, finally, the system will enter into the
panic state in "errors=panic" option.  But, in the rare case, this
sequence is little twisted like the below figure and it will happen
that the system enters into panic state, which means the system reset
in mobile environment, before completion of recording an error in the
journal superblock. In this case, e2fsck cannot recognize that the
filesystem failure occurred in the previous run and the corruption
wouldn't be fixed.

Task A                        Task B
ext4_handle_error()
-> jbd2_journal_abort()
  -> __journal_abort_soft()
    -> __jbd2_journal_abort_hard()
    | -> journal->j_flags |= JBD2_ABORT;
    |
    |                         __ext4_abort()
    |                         -> jbd2_journal_abort()
    |                         | -> __journal_abort_soft()
    |                         |   -> if (journal->j_flags & JBD2_ABORT)
    |                         |           return;
    |                         -> panic()
    |
    -> jbd2_journal_update_sb_errno()
Tested-by: default avatarHobin Woo <hobin.woo@samsung.com>
Signed-off-by: default avatarDaeho Jeong <daeho.jeong@samsung.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
parent 904dad47
...@@ -388,9 +388,13 @@ static void ext4_handle_error(struct super_block *sb) ...@@ -388,9 +388,13 @@ static void ext4_handle_error(struct super_block *sb)
smp_wmb(); smp_wmb();
sb->s_flags |= MS_RDONLY; sb->s_flags |= MS_RDONLY;
} }
if (test_opt(sb, ERRORS_PANIC)) if (test_opt(sb, ERRORS_PANIC)) {
if (EXT4_SB(sb)->s_journal &&
!(EXT4_SB(sb)->s_journal->j_flags & JBD2_REC_ERR))
return;
panic("EXT4-fs (device %s): panic forced after error\n", panic("EXT4-fs (device %s): panic forced after error\n",
sb->s_id); sb->s_id);
}
} }
#define ext4_error_ratelimit(sb) \ #define ext4_error_ratelimit(sb) \
...@@ -585,8 +589,12 @@ void __ext4_abort(struct super_block *sb, const char *function, ...@@ -585,8 +589,12 @@ void __ext4_abort(struct super_block *sb, const char *function,
jbd2_journal_abort(EXT4_SB(sb)->s_journal, -EIO); jbd2_journal_abort(EXT4_SB(sb)->s_journal, -EIO);
save_error_info(sb, function, line); save_error_info(sb, function, line);
} }
if (test_opt(sb, ERRORS_PANIC)) if (test_opt(sb, ERRORS_PANIC)) {
if (EXT4_SB(sb)->s_journal &&
!(EXT4_SB(sb)->s_journal->j_flags & JBD2_REC_ERR))
return;
panic("EXT4-fs panic from previous error\n"); panic("EXT4-fs panic from previous error\n");
}
} }
void __ext4_msg(struct super_block *sb, void __ext4_msg(struct super_block *sb,
......
...@@ -2072,8 +2072,12 @@ static void __journal_abort_soft (journal_t *journal, int errno) ...@@ -2072,8 +2072,12 @@ static void __journal_abort_soft (journal_t *journal, int errno)
__jbd2_journal_abort_hard(journal); __jbd2_journal_abort_hard(journal);
if (errno) if (errno) {
jbd2_journal_update_sb_errno(journal); jbd2_journal_update_sb_errno(journal);
write_lock(&journal->j_state_lock);
journal->j_flags |= JBD2_REC_ERR;
write_unlock(&journal->j_state_lock);
}
} }
/** /**
......
...@@ -1112,6 +1112,7 @@ JBD2_FEATURE_INCOMPAT_FUNCS(csum3, CSUM_V3) ...@@ -1112,6 +1112,7 @@ JBD2_FEATURE_INCOMPAT_FUNCS(csum3, CSUM_V3)
#define JBD2_ABORT_ON_SYNCDATA_ERR 0x040 /* Abort the journal on file #define JBD2_ABORT_ON_SYNCDATA_ERR 0x040 /* Abort the journal on file
* data write error in ordered * data write error in ordered
* mode */ * mode */
#define JBD2_REC_ERR 0x080 /* The errno in the sb has been recorded */
/* /*
* Function declarations for the journaling transaction and buffer * Function declarations for the journaling transaction and buffer
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment