Commit 435bba0f authored by Mathieu Malaterre's avatar Mathieu Malaterre Committed by Mark Brown

regmap: Remove attribute packed from struct 'regcache_rbtree_node'

On one hand commit 28644c80 ("regmap: Add the rbtree cache support")
added 'regcache_rbtree_node' as packed structure, while on the other hand
commit e977145a ("[RBTREE] Add explicit alignment to sizeof(long)
for struct rb_node.") declared struct 'rb_node' as aligned.

Solve the ambiguity of placing aligned structure in a packed one by
removing the packed attribute from struct. This seems to be the behavior
of gcc anyway.

This removes the following warning (W=1):

  drivers/base/regmap/regcache-rbtree.c:36:1: warning: alignment 1 of 'struct regcache_rbtree_node' is less than 4 [-Wpacked-not-aligned]

Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: default avatarMathieu Malaterre <malat@debian.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bfeffd15
...@@ -33,7 +33,7 @@ struct regcache_rbtree_node { ...@@ -33,7 +33,7 @@ struct regcache_rbtree_node {
unsigned int blklen; unsigned int blklen;
/* the actual rbtree node holding this block */ /* the actual rbtree node holding this block */
struct rb_node node; struct rb_node node;
} __attribute__ ((packed)); };
struct regcache_rbtree_ctx { struct regcache_rbtree_ctx {
struct rb_root root; struct rb_root root;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment