Commit 44792533 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans Verkuil

media: mxc-jpeg: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 0c43a741
...@@ -2627,7 +2627,7 @@ static const struct dev_pm_ops mxc_jpeg_pm_ops = { ...@@ -2627,7 +2627,7 @@ static const struct dev_pm_ops mxc_jpeg_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(mxc_jpeg_suspend, mxc_jpeg_resume) SET_SYSTEM_SLEEP_PM_OPS(mxc_jpeg_suspend, mxc_jpeg_resume)
}; };
static int mxc_jpeg_remove(struct platform_device *pdev) static void mxc_jpeg_remove(struct platform_device *pdev)
{ {
unsigned int slot; unsigned int slot;
struct mxc_jpeg_dev *jpeg = platform_get_drvdata(pdev); struct mxc_jpeg_dev *jpeg = platform_get_drvdata(pdev);
...@@ -2640,15 +2640,13 @@ static int mxc_jpeg_remove(struct platform_device *pdev) ...@@ -2640,15 +2640,13 @@ static int mxc_jpeg_remove(struct platform_device *pdev)
v4l2_m2m_release(jpeg->m2m_dev); v4l2_m2m_release(jpeg->m2m_dev);
v4l2_device_unregister(&jpeg->v4l2_dev); v4l2_device_unregister(&jpeg->v4l2_dev);
mxc_jpeg_detach_pm_domains(jpeg); mxc_jpeg_detach_pm_domains(jpeg);
return 0;
} }
MODULE_DEVICE_TABLE(of, mxc_jpeg_match); MODULE_DEVICE_TABLE(of, mxc_jpeg_match);
static struct platform_driver mxc_jpeg_driver = { static struct platform_driver mxc_jpeg_driver = {
.probe = mxc_jpeg_probe, .probe = mxc_jpeg_probe,
.remove = mxc_jpeg_remove, .remove_new = mxc_jpeg_remove,
.driver = { .driver = {
.name = "mxc-jpeg", .name = "mxc-jpeg",
.of_match_table = mxc_jpeg_match, .of_match_table = mxc_jpeg_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment