Commit 456aee7e authored by Eric Wheeler's avatar Eric Wheeler Committed by Ben Hutchings

bcache: fix cache_set_flush() NULL pointer dereference on OOM

commit f8b11260 upstream.

When bch_cache_set_alloc() fails to kzalloc the cache_set, the
asyncronous closure handling tries to dereference a cache_set that
hadn't yet been allocated inside of cache_set_flush() which is called
by __cache_set_unregister() during cleanup.  This appears to happen only
during an OOM condition on bcache_register.
Signed-off-by: default avatarEric Wheeler <bcache@linux.ewheeler.net>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 53285dd2
...@@ -1385,6 +1385,9 @@ static void cache_set_flush(struct closure *cl) ...@@ -1385,6 +1385,9 @@ static void cache_set_flush(struct closure *cl)
struct btree *b; struct btree *b;
unsigned i; unsigned i;
if (!c)
closure_return(cl);
bch_cache_accounting_destroy(&c->accounting); bch_cache_accounting_destroy(&c->accounting);
kobject_put(&c->internal); kobject_put(&c->internal);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment