Commit 45d04359 authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher

i40e: avoid large memcpy by assigning struct

Assign the i40e_pf structure directly instead of using a large memcpy,
which avoids a sparse warning and lets the compiler optimize the copy
since it knows the size of the structure in advance.

Change-ID: I17604e23be2616521eb760290befcb767b52b3f7
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Reviewed-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent c40918c3
...@@ -185,9 +185,11 @@ static ssize_t i40e_dbg_dump_write(struct file *filp, ...@@ -185,9 +185,11 @@ static ssize_t i40e_dbg_dump_write(struct file *filp,
if (i40e_dbg_prep_dump_buf(pf, buflen)) { if (i40e_dbg_prep_dump_buf(pf, buflen)) {
p = i40e_dbg_dump_buf; p = i40e_dbg_dump_buf;
len = sizeof(struct i40e_pf); /* avoid use of memcpy here due to sparse warning
memcpy(p, pf, len); * about copy size.
p += len; */
*((struct i40e_pf *)p) = *pf;
p += sizeof(struct i40e_pf);
len = (sizeof(struct i40e_aq_desc) len = (sizeof(struct i40e_aq_desc)
* pf->hw.aq.num_asq_entries); * pf->hw.aq.num_asq_entries);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment