Commit 45e7d78e authored by Uwe Kleine-König's avatar Uwe Kleine-König

samples: qmi: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Link: https://lore.kernel.org/r/d30beb557e0e97ea194028f62d3c4c10841d3e7c.1709886922.git.u.kleine-koenig@pengutronix.deSigned-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
parent 4998f389
...@@ -511,7 +511,7 @@ static int qmi_sample_probe(struct platform_device *pdev) ...@@ -511,7 +511,7 @@ static int qmi_sample_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int qmi_sample_remove(struct platform_device *pdev) static void qmi_sample_remove(struct platform_device *pdev)
{ {
struct qmi_sample *sample = platform_get_drvdata(pdev); struct qmi_sample *sample = platform_get_drvdata(pdev);
...@@ -520,13 +520,11 @@ static int qmi_sample_remove(struct platform_device *pdev) ...@@ -520,13 +520,11 @@ static int qmi_sample_remove(struct platform_device *pdev)
debugfs_remove(sample->de_dir); debugfs_remove(sample->de_dir);
qmi_handle_release(&sample->qmi); qmi_handle_release(&sample->qmi);
return 0;
} }
static struct platform_driver qmi_sample_driver = { static struct platform_driver qmi_sample_driver = {
.probe = qmi_sample_probe, .probe = qmi_sample_probe,
.remove = qmi_sample_remove, .remove_new = qmi_sample_remove,
.driver = { .driver = {
.name = "qmi_sample_client", .name = "qmi_sample_client",
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment