Commit 477c4b07 authored by Ralf Baechle's avatar Ralf Baechle

MIPS: VPE: Free relocation chain on error.

This may happen if a bad sequence of relocations is being encountered.
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent e2a9cf96
...@@ -462,16 +462,15 @@ static int apply_r_mips_lo16(struct module *me, uint32_t *location, ...@@ -462,16 +462,15 @@ static int apply_r_mips_lo16(struct module *me, uint32_t *location,
{ {
unsigned long insnlo = *location; unsigned long insnlo = *location;
Elf32_Addr val, vallo; Elf32_Addr val, vallo;
struct mips_hi16 *l, *next;
/* Sign extend the addend we extract from the lo insn. */ /* Sign extend the addend we extract from the lo insn. */
vallo = ((insnlo & 0xffff) ^ 0x8000) - 0x8000; vallo = ((insnlo & 0xffff) ^ 0x8000) - 0x8000;
if (mips_hi16_list != NULL) { if (mips_hi16_list != NULL) {
struct mips_hi16 *l;
l = mips_hi16_list; l = mips_hi16_list;
while (l != NULL) { while (l != NULL) {
struct mips_hi16 *next;
unsigned long insn; unsigned long insn;
/* /*
...@@ -481,7 +480,7 @@ static int apply_r_mips_lo16(struct module *me, uint32_t *location, ...@@ -481,7 +480,7 @@ static int apply_r_mips_lo16(struct module *me, uint32_t *location,
printk(KERN_DEBUG "VPE loader: " printk(KERN_DEBUG "VPE loader: "
"apply_r_mips_lo16/hi16: \t" "apply_r_mips_lo16/hi16: \t"
"inconsistent value information\n"); "inconsistent value information\n");
return -ENOEXEC; goto out_free;
} }
/* /*
...@@ -519,6 +518,16 @@ static int apply_r_mips_lo16(struct module *me, uint32_t *location, ...@@ -519,6 +518,16 @@ static int apply_r_mips_lo16(struct module *me, uint32_t *location,
*location = insnlo; *location = insnlo;
return 0; return 0;
out_free:
while (l != NULL) {
next = l->next;
kfree(l);
l = next;
}
mips_hi16_list = NULL;
return -ENOEXEC;
} }
static int (*reloc_handlers[]) (struct module *me, uint32_t *location, static int (*reloc_handlers[]) (struct module *me, uint32_t *location,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment