Commit 48d85acd authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Andreas Larsson

sparc: chmc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarAndreas Larsson <andreas@gaisler.com>
Link: https://lore.kernel.org/r/9fbd788bbca4efd2f596e3c56d045db450756c80.1712755381.git.u.kleine-koenig@pengutronix.deSigned-off-by: default avatarAndreas Larsson <andreas@gaisler.com>
parent 9f2072ca
...@@ -788,7 +788,7 @@ static void jbusmc_destroy(struct platform_device *op, struct jbusmc *p) ...@@ -788,7 +788,7 @@ static void jbusmc_destroy(struct platform_device *op, struct jbusmc *p)
kfree(p); kfree(p);
} }
static int us3mc_remove(struct platform_device *op) static void us3mc_remove(struct platform_device *op)
{ {
void *p = dev_get_drvdata(&op->dev); void *p = dev_get_drvdata(&op->dev);
...@@ -798,7 +798,6 @@ static int us3mc_remove(struct platform_device *op) ...@@ -798,7 +798,6 @@ static int us3mc_remove(struct platform_device *op)
else if (mc_type == MC_TYPE_JBUS) else if (mc_type == MC_TYPE_JBUS)
jbusmc_destroy(op, p); jbusmc_destroy(op, p);
} }
return 0;
} }
static const struct of_device_id us3mc_match[] = { static const struct of_device_id us3mc_match[] = {
...@@ -815,7 +814,7 @@ static struct platform_driver us3mc_driver = { ...@@ -815,7 +814,7 @@ static struct platform_driver us3mc_driver = {
.of_match_table = us3mc_match, .of_match_table = us3mc_match,
}, },
.probe = us3mc_probe, .probe = us3mc_probe,
.remove = us3mc_remove, .remove_new = us3mc_remove,
}; };
static inline bool us3mc_platform(void) static inline bool us3mc_platform(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment