Commit 4944514e authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Rafael J. Wysocki

cpufreq: e_powersaver: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is
finding the size of a structure that has a zero-sized array at
the end, along with memory for some number of elements for that
array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we
can now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 21469df4
...@@ -323,9 +323,8 @@ static int eps_cpu_init(struct cpufreq_policy *policy) ...@@ -323,9 +323,8 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
states = 2; states = 2;
/* Allocate private data and frequency table for current cpu */ /* Allocate private data and frequency table for current cpu */
centaur = kzalloc(sizeof(*centaur) centaur = kzalloc(struct_size(centaur, freq_table, states + 1),
+ (states + 1) * sizeof(struct cpufreq_frequency_table), GFP_KERNEL);
GFP_KERNEL);
if (!centaur) if (!centaur)
return -ENOMEM; return -ENOMEM;
eps_cpu[0] = centaur; eps_cpu[0] = centaur;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment