Commit 49880263 authored by Emoly Liu's avatar Emoly Liu Committed by Greg Kroah-Hartman

staging/lustre: Fix unnecessary parentheses around variables

This patch fixes all checkpatch occurences of
"CHECK: Unnecessary parentheses around xxx"
in Lustre code.
Signed-off-by: default avatarEmoly Liu <emoly.liu@intel.com>
Signed-off-by: default avatarOleg Drokin <green@linuxhacker.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 182ae52d
...@@ -995,7 +995,7 @@ struct hsm_user_request { ...@@ -995,7 +995,7 @@ struct hsm_user_request {
/** Return pointer to data field in a hsm user request */ /** Return pointer to data field in a hsm user request */
static inline void *hur_data(struct hsm_user_request *hur) static inline void *hur_data(struct hsm_user_request *hur)
{ {
return &(hur->hur_user_item[hur->hur_request.hr_itemcount]); return &hur->hur_user_item[hur->hur_request.hr_itemcount];
} }
/** /**
......
...@@ -941,7 +941,7 @@ int lov_process_config_base(struct obd_device *obd, struct lustre_cfg *lcfg, ...@@ -941,7 +941,7 @@ int lov_process_config_base(struct obd_device *obd, struct lustre_cfg *lcfg,
} }
case LCFG_PARAM: { case LCFG_PARAM: {
struct lprocfs_static_vars lvars = { NULL }; struct lprocfs_static_vars lvars = { NULL };
struct lov_desc *desc = &(obd->u.lov.desc); struct lov_desc *desc = &obd->u.lov.desc;
if (!desc) { if (!desc) {
rc = -EINVAL; rc = -EINVAL;
...@@ -1461,7 +1461,7 @@ static int lov_iocontrol(unsigned int cmd, struct obd_export *exp, int len, ...@@ -1461,7 +1461,7 @@ static int lov_iocontrol(unsigned int cmd, struct obd_export *exp, int len,
} }
desc = (struct lov_desc *)data->ioc_inlbuf1; desc = (struct lov_desc *)data->ioc_inlbuf1;
memcpy(desc, &(lov->desc), sizeof(*desc)); memcpy(desc, &lov->desc, sizeof(*desc));
uuidp = (struct obd_uuid *)data->ioc_inlbuf2; uuidp = (struct obd_uuid *)data->ioc_inlbuf2;
genp = (__u32 *)data->ioc_inlbuf3; genp = (__u32 *)data->ioc_inlbuf3;
......
...@@ -61,7 +61,7 @@ void lov_pool_putref(struct pool_desc *pool) ...@@ -61,7 +61,7 @@ void lov_pool_putref(struct pool_desc *pool)
LASSERT(hlist_unhashed(&pool->pool_hash)); LASSERT(hlist_unhashed(&pool->pool_hash));
LASSERT(list_empty(&pool->pool_list)); LASSERT(list_empty(&pool->pool_list));
LASSERT(!pool->pool_debugfs_entry); LASSERT(!pool->pool_debugfs_entry);
lov_ost_pool_free(&(pool->pool_obds)); lov_ost_pool_free(&pool->pool_obds);
kfree(pool); kfree(pool);
} }
} }
...@@ -260,7 +260,7 @@ static int pool_proc_show(struct seq_file *s, void *v) ...@@ -260,7 +260,7 @@ static int pool_proc_show(struct seq_file *s, void *v)
tgt = pool_tgt(iter->pool, iter->idx); tgt = pool_tgt(iter->pool, iter->idx);
up_read(&pool_tgt_rw_sem(iter->pool)); up_read(&pool_tgt_rw_sem(iter->pool));
if (tgt) if (tgt)
seq_printf(s, "%s\n", obd_uuid2str(&(tgt->ltd_uuid))); seq_printf(s, "%s\n", obd_uuid2str(&tgt->ltd_uuid));
return 0; return 0;
} }
...@@ -400,7 +400,7 @@ int lov_pool_new(struct obd_device *obd, char *poolname) ...@@ -400,7 +400,7 @@ int lov_pool_new(struct obd_device *obd, char *poolname)
struct pool_desc *new_pool; struct pool_desc *new_pool;
int rc; int rc;
lov = &(obd->u.lov); lov = &obd->u.lov;
if (strlen(poolname) > LOV_MAXPOOLNAME) if (strlen(poolname) > LOV_MAXPOOLNAME)
return -ENAMETOOLONG; return -ENAMETOOLONG;
...@@ -471,7 +471,7 @@ int lov_pool_del(struct obd_device *obd, char *poolname) ...@@ -471,7 +471,7 @@ int lov_pool_del(struct obd_device *obd, char *poolname)
struct lov_obd *lov; struct lov_obd *lov;
struct pool_desc *pool; struct pool_desc *pool;
lov = &(obd->u.lov); lov = &obd->u.lov;
/* lookup and kill hash reference */ /* lookup and kill hash reference */
pool = cfs_hash_del_key(lov->lov_pools_hash_body, poolname); pool = cfs_hash_del_key(lov->lov_pools_hash_body, poolname);
...@@ -503,7 +503,7 @@ int lov_pool_add(struct obd_device *obd, char *poolname, char *ostname) ...@@ -503,7 +503,7 @@ int lov_pool_add(struct obd_device *obd, char *poolname, char *ostname)
unsigned int lov_idx; unsigned int lov_idx;
int rc; int rc;
lov = &(obd->u.lov); lov = &obd->u.lov;
pool = cfs_hash_lookup(lov->lov_pools_hash_body, poolname); pool = cfs_hash_lookup(lov->lov_pools_hash_body, poolname);
if (!pool) if (!pool)
...@@ -517,7 +517,7 @@ int lov_pool_add(struct obd_device *obd, char *poolname, char *ostname) ...@@ -517,7 +517,7 @@ int lov_pool_add(struct obd_device *obd, char *poolname, char *ostname)
if (!lov->lov_tgts[lov_idx]) if (!lov->lov_tgts[lov_idx])
continue; continue;
if (obd_uuid_equals(&ost_uuid, if (obd_uuid_equals(&ost_uuid,
&(lov->lov_tgts[lov_idx]->ltd_uuid))) &lov->lov_tgts[lov_idx]->ltd_uuid))
break; break;
} }
/* test if ost found in lov */ /* test if ost found in lov */
...@@ -547,7 +547,7 @@ int lov_pool_remove(struct obd_device *obd, char *poolname, char *ostname) ...@@ -547,7 +547,7 @@ int lov_pool_remove(struct obd_device *obd, char *poolname, char *ostname)
unsigned int lov_idx; unsigned int lov_idx;
int rc = 0; int rc = 0;
lov = &(obd->u.lov); lov = &obd->u.lov;
pool = cfs_hash_lookup(lov->lov_pools_hash_body, poolname); pool = cfs_hash_lookup(lov->lov_pools_hash_body, poolname);
if (!pool) if (!pool)
...@@ -562,7 +562,7 @@ int lov_pool_remove(struct obd_device *obd, char *poolname, char *ostname) ...@@ -562,7 +562,7 @@ int lov_pool_remove(struct obd_device *obd, char *poolname, char *ostname)
continue; continue;
if (obd_uuid_equals(&ost_uuid, if (obd_uuid_equals(&ost_uuid,
&(lov->lov_tgts[lov_idx]->ltd_uuid))) &lov->lov_tgts[lov_idx]->ltd_uuid))
break; break;
} }
......
...@@ -166,10 +166,10 @@ int class_register_type(struct obd_ops *dt_ops, struct md_ops *md_ops, ...@@ -166,10 +166,10 @@ int class_register_type(struct obd_ops *dt_ops, struct md_ops *md_ops,
!type->typ_name) !type->typ_name)
goto failed; goto failed;
*(type->typ_dt_ops) = *dt_ops; *type->typ_dt_ops = *dt_ops;
/* md_ops is optional */ /* md_ops is optional */
if (md_ops) if (md_ops)
*(type->typ_md_ops) = *md_ops; *type->typ_md_ops = *md_ops;
strcpy(type->typ_name, name); strcpy(type->typ_name, name);
spin_lock_init(&type->obd_type_lock); spin_lock_init(&type->obd_type_lock);
......
...@@ -80,7 +80,7 @@ static void llog_free_handle(struct llog_handle *loghandle) ...@@ -80,7 +80,7 @@ static void llog_free_handle(struct llog_handle *loghandle)
LASSERT(list_empty(&loghandle->u.phd.phd_entry)); LASSERT(list_empty(&loghandle->u.phd.phd_entry));
else if (loghandle->lgh_hdr->llh_flags & LLOG_F_IS_CAT) else if (loghandle->lgh_hdr->llh_flags & LLOG_F_IS_CAT)
LASSERT(list_empty(&loghandle->u.chd.chd_head)); LASSERT(list_empty(&loghandle->u.chd.chd_head));
LASSERT(sizeof(*(loghandle->lgh_hdr)) == LLOG_CHUNK_SIZE); LASSERT(sizeof(*loghandle->lgh_hdr) == LLOG_CHUNK_SIZE);
kfree(loghandle->lgh_hdr); kfree(loghandle->lgh_hdr);
out: out:
kfree(loghandle); kfree(loghandle);
......
...@@ -214,7 +214,7 @@ static int cleanup_all_handles(void) ...@@ -214,7 +214,7 @@ static int cleanup_all_handles(void)
struct portals_handle *h; struct portals_handle *h;
spin_lock(&handle_hash[i].lock); spin_lock(&handle_hash[i].lock);
list_for_each_entry_rcu(h, &(handle_hash[i].head), h_link) { list_for_each_entry_rcu(h, &handle_hash[i].head, h_link) {
CERROR("force clean handle %#llx addr %p ops %p\n", CERROR("force clean handle %#llx addr %p ops %p\n",
h->h_cookie, h, h->h_ops); h->h_cookie, h, h->h_ops);
......
...@@ -1013,7 +1013,7 @@ int class_process_proc_param(char *prefix, struct lprocfs_vars *lvars, ...@@ -1013,7 +1013,7 @@ int class_process_proc_param(char *prefix, struct lprocfs_vars *lvars,
oldfs = get_fs(); oldfs = get_fs();
set_fs(KERNEL_DS); set_fs(KERNEL_DS);
rc = (var->fops->write)(&fakefile, sval, rc = var->fops->write(&fakefile, sval,
vallen, NULL); vallen, NULL);
set_fs(oldfs); set_fs(oldfs);
} }
......
...@@ -394,7 +394,7 @@ int lustre_start_mgc(struct super_block *sb) ...@@ -394,7 +394,7 @@ int lustre_start_mgc(struct super_block *sb)
lsi->lsi_lmd->lmd_flags & LMD_FLG_NOIR) lsi->lsi_lmd->lmd_flags & LMD_FLG_NOIR)
data->ocd_connect_flags &= ~OBD_CONNECT_IMP_RECOV; data->ocd_connect_flags &= ~OBD_CONNECT_IMP_RECOV;
data->ocd_version = LUSTRE_VERSION_CODE; data->ocd_version = LUSTRE_VERSION_CODE;
rc = obd_connect(NULL, &exp, obd, &(obd->obd_uuid), data, NULL); rc = obd_connect(NULL, &exp, obd, &obd->obd_uuid, data, NULL);
if (rc) { if (rc) {
CERROR("connect failed %d\n", rc); CERROR("connect failed %d\n", rc);
goto out; goto out;
......
...@@ -2633,7 +2633,7 @@ static int osc_getstripe(struct lov_stripe_md *lsm, ...@@ -2633,7 +2633,7 @@ static int osc_getstripe(struct lov_stripe_md *lsm,
lmm_objects = lmm_objects =
&(((struct lov_user_md_v1 *)lumk)->lmm_objects[0]); &(((struct lov_user_md_v1 *)lumk)->lmm_objects[0]);
else else
lmm_objects = &(lumk->lmm_objects[0]); lmm_objects = &lumk->lmm_objects[0];
lmm_objects->l_ost_oi = lsm->lsm_oi; lmm_objects->l_ost_oi = lsm->lsm_oi;
} else { } else {
lum_size = lov_mds_md_size(0, lum.lmm_magic); lum_size = lov_mds_md_size(0, lum.lmm_magic);
......
...@@ -1978,9 +1978,9 @@ void lustre_swab_lov_user_md_objects(struct lov_user_ost_data *lod, ...@@ -1978,9 +1978,9 @@ void lustre_swab_lov_user_md_objects(struct lov_user_ost_data *lod,
int i; int i;
for (i = 0; i < stripe_count; i++) { for (i = 0; i < stripe_count; i++) {
lustre_swab_ost_id(&(lod[i].l_ost_oi)); lustre_swab_ost_id(&lod[i].l_ost_oi);
__swab32s(&(lod[i].l_ost_gen)); __swab32s(&lod[i].l_ost_gen);
__swab32s(&(lod[i].l_ost_idx)); __swab32s(&lod[i].l_ost_idx);
} }
} }
EXPORT_SYMBOL(lustre_swab_lov_user_md_objects); EXPORT_SYMBOL(lustre_swab_lov_user_md_objects);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment