Commit 49aad901 authored by Axel Lin's avatar Axel Lin Committed by Greg Kroah-Hartman

hwmon: (sis5595) Prevent overflow problem when writing large limits

commit cc336546 upstream.

On platforms with sizeof(int) < sizeof(long), writing a temperature
limit larger than MAXINT will result in unpredictable limit values
written to the chip. Avoid auto-conversion from long to int to fix
the problem.
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4f46f895
...@@ -159,7 +159,7 @@ static inline int TEMP_FROM_REG(s8 val) ...@@ -159,7 +159,7 @@ static inline int TEMP_FROM_REG(s8 val)
{ {
return val * 830 + 52120; return val * 830 + 52120;
} }
static inline s8 TEMP_TO_REG(int val) static inline s8 TEMP_TO_REG(long val)
{ {
int nval = clamp_val(val, -54120, 157530) ; int nval = clamp_val(val, -54120, 157530) ;
return nval < 0 ? (nval - 5212 - 415) / 830 : (nval - 5212 + 415) / 830; return nval < 0 ? (nval - 5212 - 415) / 830 : (nval - 5212 + 415) / 830;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment