Commit 4a24efa1 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Jens Axboe

sata_highbank: fix deferred probing

The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver would fail the probe
permanently instead of the deferred probing. Switch to propagating the
error code upstream, still checking/overriding IRQ0 as libata regards it
as "no IRQ" (thus polling) anyway...

Fixes: 9ec36caf ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omprussia.ru>
Link: https://lore.kernel.org/r/105b456d-1199-f6e9-ceb7-ffc5ba551d1a@omprussia.ruSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 14fe1e85
...@@ -469,10 +469,12 @@ static int ahci_highbank_probe(struct platform_device *pdev) ...@@ -469,10 +469,12 @@ static int ahci_highbank_probe(struct platform_device *pdev)
} }
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (irq <= 0) { if (irq < 0) {
dev_err(dev, "no irq\n"); dev_err(dev, "no irq\n");
return -EINVAL; return irq;
} }
if (!irq)
return -EINVAL;
hpriv = devm_kzalloc(dev, sizeof(*hpriv), GFP_KERNEL); hpriv = devm_kzalloc(dev, sizeof(*hpriv), GFP_KERNEL);
if (!hpriv) { if (!hpriv) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment