Commit 4a38e733 authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik

pata_ali: use atapi_cmd_type() to determine cmd type instead of transfer size

pata_ali was using qc->nbytes to determine whether a command is
data transfer type or not.  As now qc->nbytes can be extended by
padding and draining buffers, these tests are not useful anymore.

Use atapi_cmd_type() instead.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent a22e6444
...@@ -295,7 +295,7 @@ static void ali_lock_sectors(struct ata_device *adev) ...@@ -295,7 +295,7 @@ static void ali_lock_sectors(struct ata_device *adev)
static int ali_check_atapi_dma(struct ata_queued_cmd *qc) static int ali_check_atapi_dma(struct ata_queued_cmd *qc)
{ {
/* If its not a media command, its not worth it */ /* If its not a media command, its not worth it */
if (qc->nbytes < 2048) if (atapi_cmd_type(qc->cdb[0]) == ATAPI_MISC)
return -EOPNOTSUPP; return -EOPNOTSUPP;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment