Commit 4a4d371a authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo

perf record: Remove -f/--force option

It no longer have any affect on the processing and is marked as obsolete
anyway.
Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-tvwyspiqr4getzfib2lw06ty@git.kernel.org
Link: http://lkml.kernel.org/r/1372307120-737-1-git-send-email-namhyung@kernel.org
[ combined patch removing the -f usage in various sub-commands, such as 'perf sched', etc, by Namhyung Kim ]
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 563aecb2
...@@ -66,7 +66,7 @@ Furthermore, these tracepoints can be used to sample the workload as ...@@ -66,7 +66,7 @@ Furthermore, these tracepoints can be used to sample the workload as
well. For example the page allocations done by a 'git gc' can be well. For example the page allocations done by a 'git gc' can be
captured the following way: captured the following way:
titan:~/git> perf record -f -e kmem:mm_page_alloc -c 1 ./git gc titan:~/git> perf record -e kmem:mm_page_alloc -c 1 ./git gc
Counting objects: 1148, done. Counting objects: 1148, done.
Delta compression using up to 2 threads. Delta compression using up to 2 threads.
Compressing objects: 100% (450/450), done. Compressing objects: 100% (450/450), done.
...@@ -120,7 +120,7 @@ Furthermore, call-graph sampling can be done too, of page ...@@ -120,7 +120,7 @@ Furthermore, call-graph sampling can be done too, of page
allocations - to see precisely what kind of page allocations there allocations - to see precisely what kind of page allocations there
are: are:
titan:~/git> perf record -f -g -e kmem:mm_page_alloc -c 1 ./git gc titan:~/git> perf record -g -e kmem:mm_page_alloc -c 1 ./git gc
Counting objects: 1148, done. Counting objects: 1148, done.
Delta compression using up to 2 threads. Delta compression using up to 2 threads.
Compressing objects: 100% (450/450), done. Compressing objects: 100% (450/450), done.
......
...@@ -70,10 +70,6 @@ OPTIONS ...@@ -70,10 +70,6 @@ OPTIONS
--no-delay:: --no-delay::
Collect data without buffering. Collect data without buffering.
-f::
--force::
Overwrite existing data file. (deprecated)
-c:: -c::
--count=:: --count=::
Event period to sample. Event period to sample.
......
...@@ -708,7 +708,7 @@ static int parse_line_opt(const struct option *opt __maybe_unused, ...@@ -708,7 +708,7 @@ static int parse_line_opt(const struct option *opt __maybe_unused,
static int __cmd_record(int argc, const char **argv) static int __cmd_record(int argc, const char **argv)
{ {
const char * const record_args[] = { const char * const record_args[] = {
"record", "-a", "-R", "-f", "-c", "1", "record", "-a", "-R", "-c", "1",
"-e", "kmem:kmalloc", "-e", "kmem:kmalloc",
"-e", "kmem:kmalloc_node", "-e", "kmem:kmalloc_node",
"-e", "kmem:kfree", "-e", "kmem:kfree",
......
...@@ -878,7 +878,7 @@ static int __cmd_report(void) ...@@ -878,7 +878,7 @@ static int __cmd_report(void)
static int __cmd_record(int argc, const char **argv) static int __cmd_record(int argc, const char **argv)
{ {
const char *record_args[] = { const char *record_args[] = {
"record", "-R", "-f", "-m", "1024", "-c", "1", "record", "-R", "-m", "1024", "-c", "1",
}; };
unsigned int rec_argc, i, j; unsigned int rec_argc, i, j;
const char **rec_argv; const char **rec_argv;
......
...@@ -74,7 +74,6 @@ struct perf_record { ...@@ -74,7 +74,6 @@ struct perf_record {
int realtime_prio; int realtime_prio;
bool no_buildid; bool no_buildid;
bool no_buildid_cache; bool no_buildid_cache;
bool force;
long samples; long samples;
off_t post_processing_offset; off_t post_processing_offset;
}; };
...@@ -856,8 +855,6 @@ const struct option record_options[] = { ...@@ -856,8 +855,6 @@ const struct option record_options[] = {
"system-wide collection from all CPUs"), "system-wide collection from all CPUs"),
OPT_STRING('C', "cpu", &record.opts.target.cpu_list, "cpu", OPT_STRING('C', "cpu", &record.opts.target.cpu_list, "cpu",
"list of cpus to monitor"), "list of cpus to monitor"),
OPT_BOOLEAN('f', "force", &record.force,
"overwrite existing data file (deprecated)"),
OPT_U64('c', "count", &record.opts.user_interval, "event period to sample"), OPT_U64('c', "count", &record.opts.user_interval, "event period to sample"),
OPT_STRING('o', "output", &record.output_name, "file", OPT_STRING('o', "output", &record.output_name, "file",
"output file name"), "output file name"),
......
...@@ -1632,7 +1632,6 @@ static int __cmd_record(int argc, const char **argv) ...@@ -1632,7 +1632,6 @@ static int __cmd_record(int argc, const char **argv)
"record", "record",
"-a", "-a",
"-R", "-R",
"-f",
"-m", "1024", "-m", "1024",
"-c", "1", "-c", "1",
"-e", "sched:sched_switch", "-e", "sched:sched_switch",
......
...@@ -1005,7 +1005,7 @@ static int __cmd_record(int argc, const char **argv) ...@@ -1005,7 +1005,7 @@ static int __cmd_record(int argc, const char **argv)
{ {
#ifdef SUPPORT_OLD_POWER_EVENTS #ifdef SUPPORT_OLD_POWER_EVENTS
const char * const record_old_args[] = { const char * const record_old_args[] = {
"record", "-a", "-R", "-f", "-c", "1", "record", "-a", "-R", "-c", "1",
"-e", "power:power_start", "-e", "power:power_start",
"-e", "power:power_end", "-e", "power:power_end",
"-e", "power:power_frequency", "-e", "power:power_frequency",
...@@ -1014,7 +1014,7 @@ static int __cmd_record(int argc, const char **argv) ...@@ -1014,7 +1014,7 @@ static int __cmd_record(int argc, const char **argv)
}; };
#endif #endif
const char * const record_new_args[] = { const char * const record_new_args[] = {
"record", "-a", "-R", "-f", "-c", "1", "record", "-a", "-R", "-c", "1",
"-e", "power:cpu_frequency", "-e", "power:cpu_frequency",
"-e", "power:cpu_idle", "-e", "power:cpu_idle",
"-e", "sched:sched_wakeup", "-e", "sched:sched_wakeup",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment