Commit 4a9fb91a authored by Dmitry Baryshkov's avatar Dmitry Baryshkov

drm/msm/dpu: document INTF_EDP/INTF_DP difference

Based on the discussions on the mailing list, document enum
dpu_intf_type and it's controversial fields: INTF_DP and INTF_EDP.

INTF_EDP is used for older eDP interface found on msm8x74/msm8x84
INTF_DP is used for both eDP and DP interfaces handled by the msm/dp
driver. The DPU driver does not make a difference between them.
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/475555/
Link: https://lore.kernel.org/r/20220222062246.242577-2-dmitry.baryshkov@linaro.orgSigned-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent 1e7ac595
...@@ -217,12 +217,20 @@ enum dpu_intf { ...@@ -217,12 +217,20 @@ enum dpu_intf {
INTF_MAX INTF_MAX
}; };
/*
* Historically these values correspond to the values written to the
* DISP_INTF_SEL register, which had to programmed manually. On newer MDP
* generations this register is NOP, but we keep the values for historical
* reasons.
*/
enum dpu_intf_type { enum dpu_intf_type {
INTF_NONE = 0x0, INTF_NONE = 0x0,
INTF_DSI = 0x1, INTF_DSI = 0x1,
INTF_HDMI = 0x3, INTF_HDMI = 0x3,
INTF_LCDC = 0x5, INTF_LCDC = 0x5,
/* old eDP found on 8x74 and 8x84 */
INTF_EDP = 0x9, INTF_EDP = 0x9,
/* both DP and eDP, handled by the new DP driver */
INTF_DP = 0xa, INTF_DP = 0xa,
INTF_TYPE_MAX, INTF_TYPE_MAX,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment