Commit 4acc5be3 authored by Emil Velikov's avatar Emil Velikov Committed by Emil Velikov

drm: plug memory leak on drm_setup() failure

Currently we fail to free and detach the drm_file when drm_setup() fails.
Use the drm_close_helper to do address that.
Signed-off-by: default avatarEmil Velikov <emil.velikov@collabora.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190114084410.15266-2-emil.l.velikov@gmail.com
parent e21710a8
...@@ -330,8 +330,10 @@ int drm_open(struct inode *inode, struct file *filp) ...@@ -330,8 +330,10 @@ int drm_open(struct inode *inode, struct file *filp)
goto err_undo; goto err_undo;
if (need_setup) { if (need_setup) {
retcode = drm_setup(dev); retcode = drm_setup(dev);
if (retcode) if (retcode) {
drm_close_helper(filp);
goto err_undo; goto err_undo;
}
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment