Commit 4c52b1da authored by Andrzej Hajda's avatar Andrzej Hajda Committed by David S. Miller

bna: fix error handling

Several functions can return negative value in case of error,
so their return type should be fixed as well as type of variables
to which this value is assigned.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3504bb63
...@@ -1543,7 +1543,7 @@ bfa_flash_cmd_act_check(void __iomem *pci_bar) ...@@ -1543,7 +1543,7 @@ bfa_flash_cmd_act_check(void __iomem *pci_bar)
} }
/* Flush FLI data fifo. */ /* Flush FLI data fifo. */
static u32 static int
bfa_flash_fifo_flush(void __iomem *pci_bar) bfa_flash_fifo_flush(void __iomem *pci_bar)
{ {
u32 i; u32 i;
...@@ -1573,11 +1573,11 @@ bfa_flash_fifo_flush(void __iomem *pci_bar) ...@@ -1573,11 +1573,11 @@ bfa_flash_fifo_flush(void __iomem *pci_bar)
} }
/* Read flash status. */ /* Read flash status. */
static u32 static int
bfa_flash_status_read(void __iomem *pci_bar) bfa_flash_status_read(void __iomem *pci_bar)
{ {
union bfa_flash_dev_status_reg dev_status; union bfa_flash_dev_status_reg dev_status;
u32 status; int status;
u32 ret_status; u32 ret_status;
int i; int i;
...@@ -1611,11 +1611,11 @@ bfa_flash_status_read(void __iomem *pci_bar) ...@@ -1611,11 +1611,11 @@ bfa_flash_status_read(void __iomem *pci_bar)
} }
/* Start flash read operation. */ /* Start flash read operation. */
static u32 static int
bfa_flash_read_start(void __iomem *pci_bar, u32 offset, u32 len, bfa_flash_read_start(void __iomem *pci_bar, u32 offset, u32 len,
char *buf) char *buf)
{ {
u32 status; int status;
/* len must be mutiple of 4 and not exceeding fifo size */ /* len must be mutiple of 4 and not exceeding fifo size */
if (len == 0 || len > BFA_FLASH_FIFO_SIZE || (len & 0x03) != 0) if (len == 0 || len > BFA_FLASH_FIFO_SIZE || (len & 0x03) != 0)
...@@ -1703,7 +1703,8 @@ static enum bfa_status ...@@ -1703,7 +1703,8 @@ static enum bfa_status
bfa_flash_raw_read(void __iomem *pci_bar, u32 offset, char *buf, bfa_flash_raw_read(void __iomem *pci_bar, u32 offset, char *buf,
u32 len) u32 len)
{ {
u32 n, status; u32 n;
int status;
u32 off, l, s, residue, fifo_sz; u32 off, l, s, residue, fifo_sz;
residue = len; residue = len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment