Commit 4d7b4483 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

net: amd8111e: remove redundant duplicated if statement

There are two identical nested if statements, the second is redundant
and can be removed. Also clean up white space formatting.

Cleans up cppcheck warning:
drivers/net/ethernet/amd/amd8111e.c:1080: (warning) Identical inner 'if'
condition is always true.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 22e15b6f
...@@ -1074,16 +1074,12 @@ static int amd8111e_calc_coalesce(struct net_device *dev) ...@@ -1074,16 +1074,12 @@ static int amd8111e_calc_coalesce(struct net_device *dev)
amd8111e_set_coalesce(dev,TX_INTR_COAL); amd8111e_set_coalesce(dev,TX_INTR_COAL);
coal_conf->tx_coal_type = MEDIUM_COALESCE; coal_conf->tx_coal_type = MEDIUM_COALESCE;
} }
} else if (tx_pkt_size >= 1024) {
} if (coal_conf->tx_coal_type != HIGH_COALESCE) {
else if(tx_pkt_size >= 1024){ coal_conf->tx_timeout = 4;
if (tx_pkt_size >= 1024){ coal_conf->tx_event_count = 8;
if(coal_conf->tx_coal_type != HIGH_COALESCE){ amd8111e_set_coalesce(dev, TX_INTR_COAL);
coal_conf->tx_timeout = 4; coal_conf->tx_coal_type = HIGH_COALESCE;
coal_conf->tx_event_count = 8;
amd8111e_set_coalesce(dev,TX_INTR_COAL);
coal_conf->tx_coal_type = HIGH_COALESCE;
}
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment