Commit 4e3da372 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

USB: atm: ueagle-atm: fix up some permissions on the sysfs files

commit e502ac5e upstream.

Some of the sysfs files had the incorrect permissions.  Some didn't make
sense at all (writable for a file that you could not write to?)
Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Cc: Matthieu Castet <castet.matthieu@free.fr>
Cc: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: Damien Bergamini <damien.bergamini@free.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 3e4233a4
...@@ -2259,7 +2259,7 @@ static ssize_t reboot(struct device *dev, struct device_attribute *attr, ...@@ -2259,7 +2259,7 @@ static ssize_t reboot(struct device *dev, struct device_attribute *attr,
return ret; return ret;
} }
static DEVICE_ATTR(stat_status, S_IWUGO | S_IRUGO, read_status, reboot); static DEVICE_ATTR(stat_status, S_IWUSR | S_IRUGO, read_status, reboot);
static ssize_t read_human_status(struct device *dev, struct device_attribute *attr, static ssize_t read_human_status(struct device *dev, struct device_attribute *attr,
char *buf) char *buf)
...@@ -2322,7 +2322,7 @@ static ssize_t read_human_status(struct device *dev, struct device_attribute *at ...@@ -2322,7 +2322,7 @@ static ssize_t read_human_status(struct device *dev, struct device_attribute *at
return ret; return ret;
} }
static DEVICE_ATTR(stat_human_status, S_IWUGO | S_IRUGO, read_human_status, NULL); static DEVICE_ATTR(stat_human_status, S_IRUGO, read_human_status, NULL);
static ssize_t read_delin(struct device *dev, struct device_attribute *attr, static ssize_t read_delin(struct device *dev, struct device_attribute *attr,
char *buf) char *buf)
...@@ -2354,7 +2354,7 @@ static ssize_t read_delin(struct device *dev, struct device_attribute *attr, ...@@ -2354,7 +2354,7 @@ static ssize_t read_delin(struct device *dev, struct device_attribute *attr,
return ret; return ret;
} }
static DEVICE_ATTR(stat_delin, S_IWUGO | S_IRUGO, read_delin, NULL); static DEVICE_ATTR(stat_delin, S_IRUGO, read_delin, NULL);
#define UEA_ATTR(name, reset) \ #define UEA_ATTR(name, reset) \
\ \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment