Commit 4e48ed88 authored by Daniel Borkmann's avatar Daniel Borkmann Committed by David S. Miller

netlink: reset network header before passing to taps

netlink doesn't set any network header offset thus when the skb is
being passed to tap devices via dev_queue_xmit_nit(), it emits klog
false positives due to it being unset like:

  ...
  [  124.990397] protocol 0000 is buggy, dev nlmon0
  [  124.990411] protocol 0000 is buggy, dev nlmon0
  ...

So just reset the network header before passing to the device; for
packet sockets that just means nothing will change - mac and net
offset hold the same value just as before.
Reported-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarDaniel Borkmann <dborkman@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f2c9bd8
...@@ -213,7 +213,7 @@ static int __netlink_deliver_tap_skb(struct sk_buff *skb, ...@@ -213,7 +213,7 @@ static int __netlink_deliver_tap_skb(struct sk_buff *skb,
nskb->protocol = htons((u16) sk->sk_protocol); nskb->protocol = htons((u16) sk->sk_protocol);
nskb->pkt_type = netlink_is_kernel(sk) ? nskb->pkt_type = netlink_is_kernel(sk) ?
PACKET_KERNEL : PACKET_USER; PACKET_KERNEL : PACKET_USER;
skb_reset_network_header(nskb);
ret = dev_queue_xmit(nskb); ret = dev_queue_xmit(nskb);
if (unlikely(ret > 0)) if (unlikely(ret > 0))
ret = net_xmit_errno(ret); ret = net_xmit_errno(ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment