Commit 4ecc4a18 authored by Ksenija Stanojevic's avatar Ksenija Stanojevic Committed by Greg Kroah-Hartman

Staging: rdma: Use memdup_user

Use memdup_user when user data is immediately copied into the
allocated region.

Issue found using coccinelle.

Signed-off-by: Ksenija Stanojevic<ksenija.stanojevic@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 514d4d74
...@@ -195,16 +195,9 @@ static ssize_t flash_write(struct file *file, const char __user *buf, ...@@ -195,16 +195,9 @@ static ssize_t flash_write(struct file *file, const char __user *buf,
goto bail; goto bail;
} }
tmp = kmalloc(count, GFP_KERNEL); tmp = memdup_user(buf, count);
if (!tmp) { if (IS_ERR(tmp))
ret = -ENOMEM; return PTR_ERR(tmp);
goto bail;
}
if (copy_from_user(tmp, buf, count)) {
ret = -EFAULT;
goto bail_tmp;
}
dd = file_inode(file)->i_private; dd = file_inode(file)->i_private;
if (ipath_eeprom_write(dd, pos, tmp, count)) { if (ipath_eeprom_write(dd, pos, tmp, count)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment