Commit 4f1354d5 authored by Zhen Lei's avatar Zhen Lei Committed by Luis Chamberlain

livepatch: Call klp_match_callback() in klp_find_callback() to avoid code duplication

The implementation of function klp_match_callback() is identical to the
partial implementation of function klp_find_callback(). So call function
klp_match_callback() in function klp_find_callback() instead of the
duplicated code.
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Acked-by: default avatarSong Liu <song@kernel.org>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Suggested-by: default avatarPetr Mladek <pmladek@suse.com>
Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
parent 169a58ad
...@@ -125,20 +125,10 @@ struct klp_find_arg { ...@@ -125,20 +125,10 @@ struct klp_find_arg {
unsigned long pos; unsigned long pos;
}; };
static int klp_find_callback(void *data, const char *name, static int klp_match_callback(void *data, unsigned long addr)
struct module *mod, unsigned long addr)
{ {
struct klp_find_arg *args = data; struct klp_find_arg *args = data;
if ((mod && !args->objname) || (!mod && args->objname))
return 0;
if (strcmp(args->name, name))
return 0;
if (args->objname && strcmp(args->objname, mod->name))
return 0;
args->addr = addr; args->addr = addr;
args->count++; args->count++;
...@@ -153,22 +143,21 @@ static int klp_find_callback(void *data, const char *name, ...@@ -153,22 +143,21 @@ static int klp_find_callback(void *data, const char *name,
return 0; return 0;
} }
static int klp_match_callback(void *data, unsigned long addr) static int klp_find_callback(void *data, const char *name,
struct module *mod, unsigned long addr)
{ {
struct klp_find_arg *args = data; struct klp_find_arg *args = data;
args->addr = addr; if ((mod && !args->objname) || (!mod && args->objname))
args->count++; return 0;
/* if (strcmp(args->name, name))
* Finish the search when the symbol is found for the desired position return 0;
* or the position is not defined for a non-unique symbol.
*/
if ((args->pos && (args->count == args->pos)) ||
(!args->pos && (args->count > 1)))
return 1;
return 0; if (args->objname && strcmp(args->objname, mod->name))
return 0;
return klp_match_callback(data, addr);
} }
static int klp_find_object_symbol(const char *objname, const char *name, static int klp_find_object_symbol(const char *objname, const char *name,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment