Commit 5074b85b authored by Jan Beulich's avatar Jan Beulich Committed by Thomas Gleixner

x86: hpet: Fix inverted return value check in arch_setup_hpet_msi()

setup_hpet_msi_remapped() returns a negative error indicator on error
- check for this rather than for a boolean false indication, and pass
on that error code rather than a meaningless "-1".
Signed-off-by: default avatarJan Beulich <jbeulich@suse.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Link: http://lkml.kernel.org/r/5093E00D02000078000A60E2@nat28.tlf.novell.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 6acf5a8c
...@@ -3317,8 +3317,9 @@ int arch_setup_hpet_msi(unsigned int irq, unsigned int id) ...@@ -3317,8 +3317,9 @@ int arch_setup_hpet_msi(unsigned int irq, unsigned int id)
int ret; int ret;
if (irq_remapping_enabled) { if (irq_remapping_enabled) {
if (!setup_hpet_msi_remapped(irq, id)) ret = setup_hpet_msi_remapped(irq, id);
return -1; if (ret)
return ret;
} }
ret = msi_compose_msg(NULL, irq, &msg, id); ret = msi_compose_msg(NULL, irq, &msg, id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment