Commit 5080ca0f authored by Samuel Holland's avatar Samuel Holland Committed by Palmer Dabbelt

riscv: Simplify text patching loops

This reduces the number of variables and makes the code easier to parse.
Signed-off-by: default avatarSamuel Holland <samuel.holland@sifive.com>
Reviewed-by: default avatarBjörn Töpel <bjorn@rivosinc.com>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20240327160520.791322-5-samuel.holland@sifive.comSigned-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent b1756750
...@@ -163,22 +163,24 @@ NOKPROBE_SYMBOL(__patch_insn_write); ...@@ -163,22 +163,24 @@ NOKPROBE_SYMBOL(__patch_insn_write);
static int patch_insn_set(void *addr, u8 c, size_t len) static int patch_insn_set(void *addr, u8 c, size_t len)
{ {
size_t patched = 0;
size_t size; size_t size;
int ret = 0; int ret;
/* /*
* __patch_insn_set() can only work on 2 pages at a time so call it in a * __patch_insn_set() can only work on 2 pages at a time so call it in a
* loop with len <= 2 * PAGE_SIZE. * loop with len <= 2 * PAGE_SIZE.
*/ */
while (patched < len && !ret) { while (len) {
size = min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr + patched), len - patched); size = min(len, PAGE_SIZE * 2 - offset_in_page(addr));
ret = __patch_insn_set(addr + patched, c, size); ret = __patch_insn_set(addr, c, size);
if (ret)
patched += size; return ret;
addr += size;
len -= size;
} }
return ret; return 0;
} }
NOKPROBE_SYMBOL(patch_insn_set); NOKPROBE_SYMBOL(patch_insn_set);
...@@ -198,22 +200,25 @@ NOKPROBE_SYMBOL(patch_text_set_nosync); ...@@ -198,22 +200,25 @@ NOKPROBE_SYMBOL(patch_text_set_nosync);
int patch_insn_write(void *addr, const void *insn, size_t len) int patch_insn_write(void *addr, const void *insn, size_t len)
{ {
size_t patched = 0;
size_t size; size_t size;
int ret = 0; int ret;
/* /*
* Copy the instructions to the destination address, two pages at a time * Copy the instructions to the destination address, two pages at a time
* because __patch_insn_write() can only handle len <= 2 * PAGE_SIZE. * because __patch_insn_write() can only handle len <= 2 * PAGE_SIZE.
*/ */
while (patched < len && !ret) { while (len) {
size = min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr + patched), len - patched); size = min(len, PAGE_SIZE * 2 - offset_in_page(addr));
ret = __patch_insn_write(addr + patched, insn + patched, size); ret = __patch_insn_write(addr, insn, size);
if (ret)
patched += size; return ret;
addr += size;
insn += size;
len -= size;
} }
return ret; return 0;
} }
NOKPROBE_SYMBOL(patch_insn_write); NOKPROBE_SYMBOL(patch_insn_write);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment