Commit 50f4c7b7 authored by Gao Feng's avatar Gao Feng Committed by Pablo Neira Ayuso

netfilter: xt_TCPMSS: Refactor the codes to decrease one condition check and more readable

The origin codes perform two condition checks with dst_mtu(skb_dst(skb))
and in_mtu. And the last statement is "min(dst_mtu(skb_dst(skb)),
in_mtu) - minlen". It may let reader think about how about the result.
Would it be negative.

Now assign the result of min(dst_mtu(skb_dst(skb)), in_mtu) to a new
variable, then only perform one condition check, and it is more readable.
Signed-off-by: default avatarGao Feng <fgao@ikuai8.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 4004d5c3
...@@ -110,18 +110,14 @@ tcpmss_mangle_packet(struct sk_buff *skb, ...@@ -110,18 +110,14 @@ tcpmss_mangle_packet(struct sk_buff *skb,
if (info->mss == XT_TCPMSS_CLAMP_PMTU) { if (info->mss == XT_TCPMSS_CLAMP_PMTU) {
struct net *net = par->net; struct net *net = par->net;
unsigned int in_mtu = tcpmss_reverse_mtu(net, skb, family); unsigned int in_mtu = tcpmss_reverse_mtu(net, skb, family);
unsigned int min_mtu = min(dst_mtu(skb_dst(skb)), in_mtu);
if (dst_mtu(skb_dst(skb)) <= minlen) { if (min_mtu <= minlen) {
net_err_ratelimited("unknown or invalid path-MTU (%u)\n", net_err_ratelimited("unknown or invalid path-MTU (%u)\n",
dst_mtu(skb_dst(skb))); min_mtu);
return -1; return -1;
} }
if (in_mtu <= minlen) { newmss = min_mtu - minlen;
net_err_ratelimited("unknown or invalid path-MTU (%u)\n",
in_mtu);
return -1;
}
newmss = min(dst_mtu(skb_dst(skb)), in_mtu) - minlen;
} else } else
newmss = info->mss; newmss = info->mss;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment