Commit 5146e0b0 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Stephen Boyd

clk: simplify __clk_init_parent()

The translation from the index into clk_core is done by
clk_core_get_parent_by_index().  The if-block for num_parents == 1
case is duplicating the code in the clk_core_get_parent_by_index().

Drop the "if (num_parents == 1)" from the special case.  Instead,
set the index to zero if .get_parent() is missing.
Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 3c8e77dd
...@@ -1669,44 +1669,14 @@ struct clk *clk_get_parent(struct clk *clk) ...@@ -1669,44 +1669,14 @@ struct clk *clk_get_parent(struct clk *clk)
} }
EXPORT_SYMBOL_GPL(clk_get_parent); EXPORT_SYMBOL_GPL(clk_get_parent);
/*
* .get_parent is mandatory for clocks with multiple possible parents. It is
* optional for single-parent clocks. Always call .get_parent if it is
* available and WARN if it is missing for multi-parent clocks.
*
* For single-parent clocks without .get_parent, first check to see if the
* .parents array exists, and if so use it to avoid an expensive tree
* traversal. If .parents does not exist then walk the tree.
*/
static struct clk_core *__clk_init_parent(struct clk_core *core) static struct clk_core *__clk_init_parent(struct clk_core *core)
{ {
struct clk_core *ret = NULL; u8 index = 0;
u8 index;
/* handle the trivial cases */
if (!core->num_parents) if (core->ops->get_parent)
goto out; index = core->ops->get_parent(core->hw);
if (core->num_parents == 1) {
if (IS_ERR_OR_NULL(core->parent))
core->parent = clk_core_lookup(core->parent_names[0]);
ret = core->parent;
goto out;
}
/* return clk_core_get_parent_by_index(core, index);
* Do our best to cache parent clocks in core->parents. This prevents
* unnecessary and expensive lookups. We don't set core->parent here;
* that is done by the calling function.
*/
index = core->ops->get_parent(core->hw);
ret = clk_core_get_parent_by_index(core, index);
out:
return ret;
} }
static void clk_core_reparent(struct clk_core *core, static void clk_core_reparent(struct clk_core *core,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment