Commit 5189fa19 authored by H. Peter Anvin's avatar H. Peter Anvin Committed by Linus Torvalds

regset: Return -EFAULT, not -EIO, on host-side memory fault

There is only one error code to return for a bad user-space buffer
pointer passed to a system call in the same address space as the
system call is executed, and that is EFAULT.  Furthermore, the
low-level access routines, which catch most of the faults, return
EFAULT already.
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
Reviewed-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarRoland McGrath <roland@hack.frob.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c8e25258
...@@ -339,7 +339,7 @@ static inline int copy_regset_to_user(struct task_struct *target, ...@@ -339,7 +339,7 @@ static inline int copy_regset_to_user(struct task_struct *target,
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (!access_ok(VERIFY_WRITE, data, size)) if (!access_ok(VERIFY_WRITE, data, size))
return -EIO; return -EFAULT;
return regset->get(target, regset, offset, size, NULL, data); return regset->get(target, regset, offset, size, NULL, data);
} }
...@@ -365,7 +365,7 @@ static inline int copy_regset_from_user(struct task_struct *target, ...@@ -365,7 +365,7 @@ static inline int copy_regset_from_user(struct task_struct *target,
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (!access_ok(VERIFY_READ, data, size)) if (!access_ok(VERIFY_READ, data, size))
return -EIO; return -EFAULT;
return regset->set(target, regset, offset, size, NULL, data); return regset->set(target, regset, offset, size, NULL, data);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment