Commit 53462f0f authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Jeff Kirsher

iavf: iavf_client: use struct_size() helper

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

size = struct_size(instance, entry, count);

This code was detected with the help of Coccinelle.
Signed-off-by: default avatar"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 06665619
...@@ -451,7 +451,7 @@ static int iavf_client_setup_qvlist(struct i40e_info *ldev, ...@@ -451,7 +451,7 @@ static int iavf_client_setup_qvlist(struct i40e_info *ldev,
struct i40e_qv_info *qv_info; struct i40e_qv_info *qv_info;
iavf_status err; iavf_status err;
u32 v_idx, i; u32 v_idx, i;
u32 msg_size; size_t msg_size;
if (adapter->aq_required) if (adapter->aq_required)
return -EAGAIN; return -EAGAIN;
...@@ -469,9 +469,8 @@ static int iavf_client_setup_qvlist(struct i40e_info *ldev, ...@@ -469,9 +469,8 @@ static int iavf_client_setup_qvlist(struct i40e_info *ldev,
} }
v_qvlist_info = (struct virtchnl_iwarp_qvlist_info *)qvlist_info; v_qvlist_info = (struct virtchnl_iwarp_qvlist_info *)qvlist_info;
msg_size = sizeof(struct virtchnl_iwarp_qvlist_info) + msg_size = struct_size(v_qvlist_info, qv_info,
(sizeof(struct virtchnl_iwarp_qv_info) * v_qvlist_info->num_vectors - 1);
(v_qvlist_info->num_vectors - 1));
adapter->client_pending |= BIT(VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP); adapter->client_pending |= BIT(VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP);
err = iavf_aq_send_msg_to_pf(&adapter->hw, err = iavf_aq_send_msg_to_pf(&adapter->hw,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment