Commit 536e785f authored by Vaibhav Gupta's avatar Vaibhav Gupta Committed by Wolfram Sang

i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume

The driver calls pci_enable_wake(...., false) in pch_i2c_suspend() as well
as pch_i2c_resume(). Either it should enable-wake the device in .suspend()
or should not invoke pci_enable_wake() at all.

Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
.suspend() and .resume().
Reported-by: default avatarBjorn Helgaas <helgaas@kernel.org>
Signed-off-by: default avatarVaibhav Gupta <vaibhavgupta40@gmail.com>
Reviewed-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent b0102a89
...@@ -879,7 +879,6 @@ static int pch_i2c_suspend(struct pci_dev *pdev, pm_message_t state) ...@@ -879,7 +879,6 @@ static int pch_i2c_suspend(struct pci_dev *pdev, pm_message_t state)
return ret; return ret;
} }
pci_enable_wake(pdev, PCI_D3hot, 0);
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_power_state(pdev, pci_choose_state(pdev, state)); pci_set_power_state(pdev, pci_choose_state(pdev, state));
...@@ -899,8 +898,6 @@ static int pch_i2c_resume(struct pci_dev *pdev) ...@@ -899,8 +898,6 @@ static int pch_i2c_resume(struct pci_dev *pdev)
return -EIO; return -EIO;
} }
pci_enable_wake(pdev, PCI_D3hot, 0);
for (i = 0; i < adap_info->ch_num; i++) for (i = 0; i < adap_info->ch_num; i++)
pch_i2c_init(&adap_info->pch_data[i]); pch_i2c_init(&adap_info->pch_data[i]);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment