Commit 53700f0c authored by hayeswang's avatar hayeswang Committed by David S. Miller

r8152: fix the coding style with checkpatch.pl

check the coding style with checkpatch.pl and fix the warnings and errors.
Signed-off-by: default avatarHayes Wang <hayeswang@realtek.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d00a90ca
...@@ -1076,8 +1076,7 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa) ...@@ -1076,8 +1076,7 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa)
return -ENODEV; return -ENODEV;
if (obj->type != ACPI_TYPE_BUFFER || obj->string.length != 0x17) { if (obj->type != ACPI_TYPE_BUFFER || obj->string.length != 0x17) {
netif_warn(tp, probe, tp->netdev, netif_warn(tp, probe, tp->netdev,
"Invalid buffer when reading pass-thru MAC addr: " "Invalid buffer for pass-thru MAC addr: (%d, %d)\n",
"(%d, %d)\n",
obj->type, obj->string.length); obj->type, obj->string.length);
goto amacout; goto amacout;
} }
...@@ -1090,8 +1089,8 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa) ...@@ -1090,8 +1089,8 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa)
ret = hex2bin(buf, obj->string.pointer + 9, 6); ret = hex2bin(buf, obj->string.pointer + 9, 6);
if (!(ret == 0 && is_valid_ether_addr(buf))) { if (!(ret == 0 && is_valid_ether_addr(buf))) {
netif_warn(tp, probe, tp->netdev, netif_warn(tp, probe, tp->netdev,
"Invalid MAC when reading pass-thru MAC addr: " "Invalid MAC for pass-thru MAC addr: %d, %pM\n",
"%d, %pM\n", ret, buf); ret, buf);
ret = -EINVAL; ret = -EINVAL;
goto amacout; goto amacout;
} }
...@@ -1111,9 +1110,9 @@ static int set_ethernet_addr(struct r8152 *tp) ...@@ -1111,9 +1110,9 @@ static int set_ethernet_addr(struct r8152 *tp)
struct sockaddr sa; struct sockaddr sa;
int ret; int ret;
if (tp->version == RTL_VER_01) if (tp->version == RTL_VER_01) {
ret = pla_ocp_read(tp, PLA_IDR, 8, sa.sa_data); ret = pla_ocp_read(tp, PLA_IDR, 8, sa.sa_data);
else { } else {
/* if this is not an RTL8153-AD, no eFuse mac pass thru set, /* if this is not an RTL8153-AD, no eFuse mac pass thru set,
* or system doesn't provide valid _SB.AMAC this will be * or system doesn't provide valid _SB.AMAC this will be
* be expected to non-zero * be expected to non-zero
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment